Bug 222865 - Add preference reseting to WebKitLegacy Windows to simplify testing reset
Summary: Add preference reseting to WebKitLegacy Windows to simplify testing reset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-06 10:29 PST by Sam Weinig
Modified: 2021-03-11 23:31 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.09 KB, patch)
2021-03-06 10:42 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-03-06 10:29:16 PST 
Add preference reseting to WebKitLegacy Windows to simplify testing reset
Comment 1 Sam Weinig 2021-03-06 10:42:02 PST 
Created attachment 422499 [details]
Patch
Comment 2 Sam Weinig 2021-03-07 09:52:47 PST 
Not sure if we have a bug about it already, but filed https://bugs.webkit.org/show_bug.cgi?id=222887 about the clean build issue.
Comment 3 Brent Fulgham 2021-03-08 09:43:24 PST 
Comment on attachment 422499 [details]
Patch

This change looks correct, but the build system doesn't seem to be picking up the revised header.
Comment 4 Sam Weinig 2021-03-08 14:44:04 PST 
Comment on attachment 422499 [details]
Patch

Tim told me to just land this, so I am.
Comment 5 EWS 2021-03-08 14:47:25 PST 
Committed r274111: <https://commits.webkit.org/r274111>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422499 [details].
Comment 6 Radar WebKit Bug Importer 2021-03-08 14:48:15 PST 
<rdar://problem/75188632>
Comment 7 Fujii Hironori 2021-03-11 23:31:17 PST 
Filed: Bug 223109 – [Win][WK1] Some JS tests are timing out for Debug build since r274111