Bug 223109 – [Win][WK1] Add a new API IWebPreferences::startBatchingUpdates to defer WebPreferencesChangedNotification

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Fujii Hironori]

[Win][WK1] Some JS tests are timing out for Debug build since r274111 

the first bad : 235041@main (r274111)
the last good: 235009@main (r274073)

  js/array-bad-time.html [ Timeout ]
  js/array-enumerators-functions.html [ Timeout ]
  js/comparison-operators-greater.html [ Timeout ]
  js/comparison-operators-less.html [ Timeout ]
  js/comparison-operators.html [ Timeout ]
  js/dfg-get-by-val-clobber.html [ Timeout ]
  js/dfg-get-by-val-getter-cse.html [ Timeout ]
  js/dfg-inline-arguments-out-of-bounds.html [ Timeout ]
  js/dfg-inline-many-blocks.html [ Timeout ]
  js/dfg-inline-unused-this.html [ Timeout ]
  js/dfg-inlining-reg-alloc.html [ Timeout ]
  js/dfg-integer-optimization.html [ Timeout ]
  js/dfg-intrinsic-unused-this-method-check.html [ Timeout ]
  js/dfg-intrinsic-unused-this.html [ Timeout ]
  js/dfg-mul-big-integer-with-small-integer-and-detect-overflow.html [ Timeout ]
  js/dfg-multiply.html [ Timeout ]
  js/dfg-put-by-id-prototype-check.html [ Timeout ]
  js/dfg-resolve-global-polymorphic-non-dictionary.html [ Timeout ]
  js/dfg-resolve-global-specific-dictionary.html [ Timeout ]
  js/dfg-string-stricteq.html [ Timeout ]
  js/dfg-to-string-int-or-string.html [ Timeout ]
  js/dfg-use-function-as-variable-merge-structure.html [ Timeout ]
  js/dfg-weak-js-constant-silent-fill.html [ Timeout ]
  js/dom/dfg-put-by-id-allocate-storage-polymorphic.html [ Timeout ]
  js/dom/dfg-put-by-id-allocate-storage.html [ Timeout ]
  js/dom/dfg-put-by-id-reallocate-storage-polymorphic.html [ Timeout ]
  js/dom/dfg-put-by-id-reallocate-storage.html [ Timeout ]
  js/dom/dfg-strcat-over-objects-then-exit-on-it.html [ Timeout ]
  js/dom/document-all-between-frames.html [ Timeout ]
  js/dom/document-all-triggers-masquerades-watchpoint.html [ Timeout ]
  js/dom/reserved-words-as-property.html [ Timeout ]
  js/dom/toInt32UInt32.html [ Timeout ]
  js/integer-division-neg2tothe32-by-neg1.html [ Timeout ]
  js/kde/encode_decode_uri.html [ Timeout ]
  js/math-transforms.html [ Timeout ]
  js/object-bad-time.html [ Timeout ]
  js/parser-syntax-check.html [ Timeout ]

[Fujii Hironori]

See also: Bug 220145 – [Win][DumpRenderTree] Some JS tests are timing out only in Debug builds since r269157

[Fujii Hironori]

Apple-Win-10-Debug-Tests is broken these days.
https://build.webkit.org/#/builders/16

[Fujii Hironori]

WinCairo buildbot

(In reply to Fujii Hironori from comment #0)
> the first bad : 235041@main (r274111)

https://build.webkit.org/#/builders/32/builds/140

> the last good: 235009@main (r274073)

https://build.webkit.org/#/builders/32/builds/139

[Fujii Hironori]

Mac port has _batchUpdatePreferencesInBlock to defer _postPreferencesChangedNotification.

Bug 218024 – Simplify DumpRenderTree WebPreferences reset

[Fujii Hironori]

Created attachment 423134 [details]
Patch

[Sam Weinig]

Comment on attachment 423134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423134&action=review

> Source/WebKitLegacy/win/WebPreferences.cpp:2641
> +        if (m_updateAfterBatch) {

I would call this variable m_needsUpdateAfterBatch; in this case.

[Sam Weinig]

Sorry for breaking this.

[Fujii Hironori]

Created attachment 423138 [details]
Patch for landing

[EWS]

Committed r274407: <https://commits.webkit.org/r274407>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423138 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75413551>

[Fujii Hironori]

*** Bug 220699 has been marked as a duplicate of this bug. ***