RESOLVED FIXED222597
Make build.webkit.org loadconfig similar to EWS 
https://bugs.webkit.org/show_bug.cgi?id=222597
Summary Make build.webkit.org loadconfig similar to EWS
Aakash Jain
Reported 2021-03-02 07:23:39 PST
loadconfig.py and its unit-tests in EWS have lot more checks than build.webkit.org one. We should make them similar, so that build.webkit.org also gets all those unit-tests and checks. We should also try to converge both files, so that in long-term we can share this code for both these services, instead of maintaining two copies of similar logic.
Attachments
Patch (20.02 KB, patch)
2021-03-02 08:06 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-03-02 08:06:58 PST
Created attachment 421935 [details] Patch
Aakash Jain
Comment 2 2021-03-02 08:12:38 PST
(In reply to Aakash Jain from comment #1) > Created attachment 421935 [details] > Patch Tested on dev instance.
Aakash Jain
Comment 3 2021-03-02 08:14:17 PST
This would also prevent mistakes like: https://bugs.webkit.org/show_bug.cgi?id=222501#c5
EWS
Comment 4 2021-03-02 11:18:15 PST
Committed r273742: <https://commits.webkit.org/r273742> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421935 [details].
Radar WebKit Bug Importer
Comment 5 2021-03-02 11:19:14 PST
<rdar://problem/74939318>
Note You need to log in before you can comment on or make changes to this bug.