Bug 222501 - Move WebGL test bot to Big Sur
Summary: Move WebGL test bot to Big Sur
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-26 15:48 PST by Ryan Haddad
Modified: 2021-03-02 08:13 PST (History)
6 users (show)

See Also:


Attachments
Patch (8.04 KB, patch)
2021-02-26 15:54 PST, Ryan Haddad
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2021-02-26 15:48:53 PST
Move WebGL test bot to Big Sur
Comment 1 Ryan Haddad 2021-02-26 15:49:10 PST
rdar://73900538
Comment 2 Ryan Haddad 2021-02-26 15:54:48 PST
Created attachment 421722 [details]
Patch
Comment 3 Ryan Haddad 2021-02-26 16:55:31 PST
Comment on attachment 421722 [details]
Patch

Clearing flags on attachment: 421722

Committed r273607 (234654@main): <https://commits.webkit.org/234654@main>
Comment 4 Ryan Haddad 2021-02-26 16:55:33 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Angelos Oikonomopoulos 2021-03-02 01:33:31 PST
It seems there's a trailing space in the platform value for bot1020:

{ "name": "bot1020", "platform": "mac-bigsur "}

Here, this results in the buildbot coordinator failing on startup with:

error while parsing config file: Builder Apple-BigSur-Release-WK1-Tests is for platform mac-bigsur but has worker bot1020 for platform mac-bigsur !
Comment 6 Aakash Jain 2021-03-02 07:14:36 PST
Committed r273729 (234744@main): <https://commits.webkit.org/234744@main>
Comment 7 Aakash Jain 2021-03-02 08:13:42 PST
(In reply to Angelos Oikonomopoulos from comment #5)
> It seems there's a trailing space in the platform value for bot1020:
Such issues would now cause the unit-tests to fail and ews 'services' bubble to be red, after the change in https://bugs.webkit.org/show_bug.cgi?id=222597.