Bug 222371 - [ macOS Wk2 ] imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html is a flakey text failure
Summary: [ macOS Wk2 ] imported/w3c/web-platform-tests/media-source/mediasource-active...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-24 11:12 PST by Robert Jenner
Modified: 2021-04-15 18:30 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2021-02-24 12:19 PST, Robert Jenner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-02-24 11:12:00 PST
imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html

is a flakey text failure in macOS in release and debug on Wk2. It Is also occurring on EWS, and slowing it down.  

HISTORY URL:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-source%2Fmediasource-activesourcebuffers.html&platform=mac

DIFF URL:
https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r273378%20(471)/imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers-pretty-diff.html

DIFF TEXT:
--- /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers-expected.txt
+++ /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers-actual.txt
@@ -5,6 +5,6 @@
 PASS Active SourceBuffers must appear in the same order as they appear in the sourceBuffers attribute: audio is first sourceBuffer, video media appended first
 PASS Active SourceBuffers must appear in the same order as they appear in the sourceBuffers attribute: video is first sourceBuffer, audio media appended first
 PASS Active SourceBuffers must appear in the same order as they appear in the sourceBuffers attribute: video is first sourceBuffer, video media appended first
-PASS Active SourceBuffers list reflects changes to selected audio/video tracks associated with separate SourceBuffers.
+FAIL Active SourceBuffers list reflects changes to selected audio/video tracks associated with separate SourceBuffers. assert_equals: audio source buffer no longer in the activeSourceBuffers list expected 1 but got 2
 PASS Active SourceBuffers list ignores changes to selected audio/video tracks that do not affect the activation of the SourceBuffer.
Comment 1 Radar WebKit Bug Importer 2021-02-24 11:13:01 PST
<rdar://problem/74704447>
Comment 2 Robert Jenner 2021-02-24 12:19:15 PST
Created attachment 421438 [details]
Patch
Comment 3 Robert Jenner 2021-02-24 12:32:57 PST
Was able to reproduce failure at tip of tree using the following test:

run-webkit-test imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html  --iterations 1000 -f

Same failure occurred:
+FAIL Active SourceBuffers list reflects changes to selected audio/video tracks associated with separate SourceBuffers. assert_equals: audio source buffer no longer in the activeSourceBuffers list expected 1 but got 2

Have not tracked to an obvious regress point yet. The test has been flakey for a while, but there is a point where it started to fail more frequently. Currently investigating.
Comment 4 EWS 2021-02-24 13:17:29 PST
Committed r273433: <https://commits.webkit.org/r273433>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421438 [details].
Comment 5 Truitt Savell 2021-02-24 13:27:46 PST
reopen
Comment 6 Robert Jenner 2021-02-24 14:40:33 PST
After investigating I have bisected to a regression point of r272842. 

Running the following test:
run-webkit-test imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html  --iterations 1000 -f

The same failure was reproduced. When running on r272841, the failure was not reproduced. The test was flakey failing before. However, it failed more frequently after r272842.
Comment 7 Robert Jenner 2021-04-15 18:30:37 PDT
I have added Crash to the test expectations for this test because it has been sporadically crashing.

https://trac.webkit.org/changeset/276101/webkit