Bug 221310 – [GPUP] Move UseGPUProcessForMediaEnabled from WebPreferencesInternal to WebPreferencesExperimental

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

This change will enable "UseGPUProcessForMedia" on WebKitTestRunner by default. So we will need to update TestExpectations.

[Peng Liu]

Created attachment 419095 [details]
WIP patch

[Radar WebKit Bug Importer]

<rdar://problem/74172313>

[Peng Liu]

Created attachment 419918 [details]
Update test expectations

[Peng Liu]

Created attachment 420075 [details]
WIP patch

[Peng Liu]

Created attachment 420096 [details]
WIP patch

[Peng Liu]

Created attachment 420143 [details]
WIP patch

[Peng Liu]

Created attachment 420153 [details]
Update some related API tests

[Peng Liu]

Created attachment 420175 [details]
WIP patch

[Peng Liu]

Created attachment 420205 [details]
WIP patch

[Peng Liu]

Created attachment 420210 [details]
WIP patch

[Peng Liu]

Created attachment 420225 [details]
Patch

[Sam Weinig]

Comment on attachment 420225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420225&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:70
>      auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
> -    for (_WKInternalDebugFeature *feature in [WKPreferences _internalDebugFeatures]) {
> +    for (_WKExperimentalFeature *feature in [WKPreferences _experimentalFeatures]) {
>          if ([feature.key isEqualToString:@"UseGPUProcessForMediaEnabled"]) {
> -            [[configuration preferences] _setEnabled:YES forInternalDebugFeature:feature];
> +            [[configuration preferences] _setEnabled:YES forExperimentalFeature:feature];
>              break;
>          }

So you know, there is no need to do this kind of looping for tests. You WKPreferencesSetBoolValueForKeyForTesting([configuration preferences], true, WKStringCreateWithUTF8("UseGPUProcessForMediaEnabled")); (or something like that). It will just ignore it if it doesn't know the string.

[Peng Liu]

Created attachment 420232 [details]
Revise the patch based on Sam's comment

[Peng Liu]

Comment on attachment 420225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420225&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:70
>>          }
> 
> So you know, there is no need to do this kind of looping for tests. You WKPreferencesSetBoolValueForKeyForTesting([configuration preferences], true, WKStringCreateWithUTF8("UseGPUProcessForMediaEnabled")); (or something like that). It will just ignore it if it doesn't know the string.

Good idea! Fixed. Thanks!

[Peng Liu]

Created attachment 420235 [details]
Fix build failures on iOS

[EWS]

Committed r272842: <https://commits.webkit.org/r272842>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420235 [details].

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/272842/webkit

caused 30~ test crashes on Mac Debug WK2

Build:
https://build.webkit.org/#/builders/23/builds/144

Results:
https://build.webkit.org/results/Apple-BigSur-Debug-WK2-Tests/r272842%20(144)/results.html

The history of these tests makes it fairly clear this started with r272842

[Truitt Savell]

Crash:

Application Specific Information:
CRASHING TEST: fast/canvas/webgl/texImage2D-mse-flipY-true.html

Thread 0 Crashed:
0   com.apple.JavaScriptCore      	0x00000007141e538e WTFCrash + 14 (Assertions.cpp:295)
1   com.apple.WebKit              	0x00000006e0006e0b WTFCrashWithInfo(int, char const*, char const*, int) + 27 (Assertions.h:671)
2   com.apple.WebKit              	0x00000006e089e3d8 WebKit::GPUProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 232 (GPUProcessConnectionMessageReceiver.cpp:50)
3   com.apple.WebKit              	0x00000006e00866c4 IPC::Connection::dispatchMessage(IPC::Decoder&) + 516 (Connection.cpp:1032)
4   com.apple.WebKit              	0x00000006e00877e0 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 528 (Connection.cpp:1132)
5   com.apple.WebKit              	0x00000006e0087e70 IPC::Connection::dispatchOneIncomingMessage() + 208 (Connection.cpp:1201)
6   com.apple.WebKit              	0x00000006e00a8858 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_8::operator()() + 88 (Connection.cpp:1001)
7   com.apple.WebKit              	0x00000006e00a876e WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_8, void>::call() + 30 (Function.h:52)

[Peng Liu]

Filed bug 221920 for it.