RESOLVED FIXED Bug 222327
Only import Python flatpak module on Linux 
https://bugs.webkit.org/show_bug.cgi?id=222327
Summary Only import Python flatpak module on Linux
Don Olmstead
Reported 2021-02-23 11:38:35 PST
Can't import it on Windows.
Attachments
Patch (6.97 KB, patch)
2021-02-23 12:28 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-02-23 12:28:48 PST
Created attachment 421341 [details] Patch
Jonathan Bedard
Comment 2 2021-02-23 13:43:55 PST
Comment on attachment 421341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421341&action=review > Tools/Scripts/run-bindings-tests:-39 > -flatpakutils.run_in_sandbox_if_available(sys.argv) Looks like flatpakutils already centralizes the linux check...can we not fix this Windows problem there?
Don Olmstead
Comment 3 2021-02-23 17:29:25 PST
Comment on attachment 421341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421341&action=review >> Tools/Scripts/run-bindings-tests:-39 >> -flatpakutils.run_in_sandbox_if_available(sys.argv) > > Looks like flatpakutils already centralizes the linux check...can we not fix this Windows problem there? I commented on the change that caused the issue at https://bugs.webkit.org/show_bug.cgi?id=222247#c4 which has the error. In this case it’s another issue of the signal library having differences between *nix and Windows. Honestly I think it’s safer in the long run for importing flatpack to be conditional on Linux since it’s really tied to that OS.
EWS
Comment 4 2021-02-24 06:01:11 PST
Committed r273384: <https://commits.webkit.org/r273384> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421341 [details].
Radar WebKit Bug Importer
Comment 5 2021-02-24 06:02:16 PST
<rdar://problem/74692332>
Note You need to log in before you can comment on or make changes to this bug.