Bug 222327 - Only import Python flatpak module on Linux
Summary: Only import Python flatpak module on Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 221815
  Show dependency treegraph
 
Reported: 2021-02-23 11:38 PST by Don Olmstead
Modified: 2021-02-24 06:02 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.97 KB, patch)
2021-02-23 12:28 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-02-23 11:38:35 PST
Can't import it on Windows.
Comment 1 Don Olmstead 2021-02-23 12:28:48 PST
Created attachment 421341 [details]
Patch
Comment 2 Jonathan Bedard 2021-02-23 13:43:55 PST
Comment on attachment 421341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421341&action=review

> Tools/Scripts/run-bindings-tests:-39
> -flatpakutils.run_in_sandbox_if_available(sys.argv)

Looks like flatpakutils already centralizes the linux check...can we not fix this Windows problem there?
Comment 3 Don Olmstead 2021-02-23 17:29:25 PST
Comment on attachment 421341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421341&action=review

>> Tools/Scripts/run-bindings-tests:-39
>> -flatpakutils.run_in_sandbox_if_available(sys.argv)
> 
> Looks like flatpakutils already centralizes the linux check...can we not fix this Windows problem there?

I commented on the change that caused the issue at https://bugs.webkit.org/show_bug.cgi?id=222247#c4 which has the error. In this case it’s another issue of the signal library having differences between *nix and Windows.

Honestly I think it’s safer in the long run for importing flatpack to be conditional on Linux since it’s really tied to that OS.
Comment 4 EWS 2021-02-24 06:01:11 PST
Committed r273384: <https://commits.webkit.org/r273384>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421341 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-24 06:02:16 PST
<rdar://problem/74692332>