Bug 222247 - [Flatpak SDK] gdb unusable in sandbox
Summary: [Flatpak SDK] gdb unusable in sandbox
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
Keywords: InRadar
Depends on:
Reported: 2021-02-21 04:14 PST by Philippe Normand
Modified: 2021-02-23 13:26 PST (History)
10 users (show)

See Also:

Patch (8.88 KB, patch)
2021-02-21 05:22 PST, Philippe Normand
zdobersek: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-02-21 04:14:36 PST
Because `flatpak run` catches SIGINT before gdb has a chance to, we can't interrupt a process when debugging from the SDK runtime.
Comment 1 Philippe Normand 2021-02-21 05:22:05 PST
Created attachment 421138 [details]
Comment 2 Philippe Normand 2021-02-22 04:30:03 PST
Committed r273240 (234426@main): <https://commits.webkit.org/234426@main>
Comment 3 Radar WebKit Bug Importer 2021-02-22 04:31:14 PST
Comment 4 Don Olmstead 2021-02-23 13:26:40 PST
This broke running test-webkitpy on Windows.

python3 ./Tools/Scripts/test-webkitpy --verbose --buildbot-master build.webkit.org --builder-name WinCairo-64-bit-WKL-Release-Tests --build-number 214 --buildbot-worker wincairo-wkl-release-tests-01 --report https://results.webkit.org
 in dir C:\BW\wincairo-wkl-release-tests\build (timeout 1200 secs)
 watching logfiles {}
 argv: ['python3', './Tools/Scripts/test-webkitpy', '--verbose', '--buildbot-master', 'build.webkit.org', '--builder-name', 'WinCairo-64-bit-WKL-Release-Tests', '--build-number', '214', '--buildbot-worker', 'wincairo-wkl-release-tests-01', '--report', 'https://results.webkit.org']
 using PTY: False
Traceback (most recent call last):
  File "./Tools/Scripts/test-webkitpy", line 35, in <module>
    import flatpakutils
  File ".\Tools\flatpak\flatpakutils.py", line 399, in <module>
    def disable_signals(signals=[signal.SIGINT, signal.SIGTERM, signal.SIGHUP]):
AttributeError: module 'signal' has no attribute 'SIGHUP'
program finished with exit code 1

Please review https://bugs.webkit.org/show_bug.cgi?id=222327 which works around this change. Thanks!