Bug 222317 - Enable WebXR tests cross platform
Summary: Enable WebXR tests cross platform
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 208988
  Show dependency tree / graph
 
Reported: 2021-02-23 08:51 PST by Imanol Fernandez
Modified: 2021-11-11 13:03 PST (History)
9 users (show)

See Also:

Attachments
Patch (14.18 KB, patch)
2021-02-23 08:55 PST, Imanol Fernandez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Imanol Fernandez 2021-02-23 08:51:20 PST 
Currently WebXR WPT tests are enabled in the WPE platform. We can enable them cross-platform.
Comment 1 Imanol Fernandez 2021-02-23 08:55:01 PST 
Created attachment 421317 [details]
Patch
Comment 2 Sergio Villar Senin 2021-02-24 05:09:04 PST 
Not sure what's the purpose of the patch. So far WPE is the only port building WebXR with OpenXR by default so any other platform will fail...
Comment 3 Imanol Fernandez 2021-02-24 05:14:10 PST 
(In reply to Sergio Villar Senin from comment #2)
> Not sure what's the purpose of the patch. So far WPE is the only port
> building WebXR with OpenXR by default so any other platform will fail...

It was enabled on cocoa too: https://bugs.webkit.org/show_bug.cgi?id=219171
Comment 4 Radar WebKit Bug Importer 2021-03-02 08:52:14 PST 
<rdar://problem/74930991>
Comment 5 Imanol Fernandez 2021-04-26 02:26:40 PDT 
I'm waiting for bug 224935 to land before rebasing this patch.

Would it be possible to enable the WebXR tests cross platform using the WebFakeXRDevice? Or is it required to enable WEBXR by default on the platform?
Comment 6 pabu 2021-11-11 13:03:04 PST 
Bug 224935 was seemingly resolved half a year ago so apparently this is waiting for something else then?