Turn on ENABLE_WEBXR for Cocoa rdar://71524773
Created attachment 414623 [details] Patch
Created attachment 414627 [details] Patch
Created attachment 414629 [details] Patch
Comment on attachment 414629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414629&action=review > Source/WebCore/Modules/webxr/WebXRRigidTransform.h:41 > + WTF_MAKE_ISO_ALLOCATED_EXPORT(WebXRRigidTransform, WEBCORE_EXPORT); Are these for WebKit's use, or just WebCoreTestSupport? If the latter, you can WEBCORE_TESTSUPPORT_EXPORT > Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:20 > +#if ENABLE(WEBXR) && USE_OPENXR should be USE(OPENXR), not USE_OPENXR. Ditto in a bunch of places.
(In reply to Tim Horton from comment #4) > Comment on attachment 414629 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414629&action=review > > > Source/WebCore/Modules/webxr/WebXRRigidTransform.h:41 > > + WTF_MAKE_ISO_ALLOCATED_EXPORT(WebXRRigidTransform, WEBCORE_EXPORT); > > Are these for WebKit's use, or just WebCoreTestSupport? If the latter, you > can WEBCORE_TESTSUPPORT_EXPORT /nevermind/! That is not the macro I thought it was.
Created attachment 414642 [details] Patch
Committed r270067: <https://trac.webkit.org/changeset/270067> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414642 [details].