Bug 222286 - aspect-ratio shows in computed style when disabled
Summary: aspect-ratio shows in computed style when disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks: 47738
  Show dependency tree / graph
 
Reported: 2021-02-22 13:05 PST by Simon Fraser (smfr)
Modified: 2021-02-23 09:51 PST (History)
11 users (show)

See Also:

Attachments
Test (551 bytes, text/html)
2021-02-22 13:05 PST, Simon Fraser (smfr) 		no flags Details
Patch (4.78 KB, patch)
2021-02-23 01:36 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (6.00 KB, patch)
2021-02-23 05:15 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-02-22 13:05:09 PST 
'aspect-ratio' is leaking out in computed style when the feature is disabled.
Comment 1 Simon Fraser (smfr) 2021-02-22 13:05:31 PST 
Created attachment 421230 [details]
Test
Comment 2 Rob Buis 2021-02-23 01:36:27 PST 
Created attachment 421292 [details]
Patch
Comment 3 Rob Buis 2021-02-23 05:15:58 PST 
Created attachment 421302 [details]
Patch
Comment 4 Rob Buis 2021-02-23 07:28:46 PST 
Comment on attachment 421302 [details]
Patch

Note there is some overlap with https://bugs.webkit.org/show_bug.cgi?id=222280, combined aspect-ratio-invalidate-if-disabled.html should fully pass. I don't have a preference which one lands first.
Comment 5 Sam Sneddon [:gsnedders] 2021-02-23 07:37:51 PST 
Perhaps dupe of bug 217802?
Comment 6 Rob Buis 2021-02-23 07:51:40 PST 
(In reply to Sam Sneddon [:gsnedders] from comment #5)
> Perhaps dupe of bug 217802?

Bug 217802 predates aspect-ratio (at least the newly restarted feature).
If I understand things correctly bug 222280 would also fix 217802 though.
Comment 7 Simon Fraser (smfr) 2021-02-23 09:33:16 PST 
Please land this first.
Comment 8 EWS 2021-02-23 09:50:36 PST 
Committed r273314: <https://commits.webkit.org/r273314>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421302 [details].
Comment 9 Radar WebKit Bug Importer 2021-02-23 09:51:15 PST 
<rdar://problem/74646701>