REOPENED 222279
Make system console logging synchronous 
https://bugs.webkit.org/show_bug.cgi?id=222279
Summary Make system console logging synchronous
Alicia Boya García
Reported 2021-02-22 11:07:33 PST
Previously, the logging of messages to the system console was done in PageConsoleClient::addMessage(), which was called by Document::addConsoleMessage(). The latter was called in a TaskQueue callback. This had the unfortunate side effect of adding a delay from the time a macro such as ALWAYS_LOG() is called and the text being printed to the console. This is particularly a problem when logging 3rd party libraries that don't use the WebKit logging API to log to stderr, such as GStreamer, since it causes messages logged by WebKit to not be synchronized with messages logged by 3rd party libraries or logging systems. As a consequence the usefulness of WebKit logs is noticeably reduced. This patch fixes the issue by moving the code logging to the system console to the synchronous part of Document::didLogMessage(), while still handling the rest in the m_logMessageTaskQueue callback.
Attachments
Patch (5.30 KB, patch)
2021-02-22 11:11 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (5.26 KB, patch)
2021-02-23 02:21 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2021-02-22 11:11:39 PST
Created attachment 421214 [details] Patch
Alicia Boya García
Comment 2 2021-02-23 02:21:35 PST
Created attachment 421294 [details] Patch
EWS
Comment 3 2021-02-23 12:10:01 PST
Committed r273329: <https://commits.webkit.org/r273329> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421294 [details].
Radar WebKit Bug Importer
Comment 4 2021-02-23 12:11:13 PST
<rdar://problem/74654614>
Timothy Hatcher
Comment 5 2021-06-16 10:06:19 PDT
This change broke logging most errors like CSP and promise rejections to the system console. Those do not go through Document::didLogMessage(), they call Document::addConsoleMessage() directly.
Timothy Hatcher
Comment 6 2021-06-16 10:35:23 PDT Comment hidden (obsolete)
Timothy Hatcher
Comment 7 2021-06-16 10:36:55 PDT
Re-opened since this is blocked by bug 227080.
Alicia Boya García
Comment 8 2021-06-16 11:34:23 PDT
Can reproduce. Will investigate.
Note You need to log in before you can comment on or make changes to this bug.