Bug 227080 - REGRESSION (r273329): Logging of most errors like CSP and promise rejections fail logging to the system console
Summary: REGRESSION (r273329): Logging of most errors like CSP and promise rejections ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks: 222279
  Show dependency tree / graph
 
Reported: 2021-06-16 10:33 PDT by Timothy Hatcher
Modified: 2021-06-16 12:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2021-06-16 11:15 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (4.50 KB, patch)
2021-06-16 11:16 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2021-06-16 10:33:52 PDT 
This regressed by bug 222279 (https://commits.webkit.org/r273329) since many places log directly through Document::addConsoleMessage() directly, they do not go through Document::didLogMessage().
Comment 1 Timothy Hatcher 2021-06-16 11:15:14 PDT Comment hidden (obsolete)
Comment 2 Timothy Hatcher 2021-06-16 11:16:39 PDT 
Created attachment 431570 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-06-16 11:17:32 PDT 
<rdar://problem/79407076>
Comment 4 EWS 2021-06-16 12:01:50 PDT 
Committed r278947 (238876@main): <https://commits.webkit.org/238876@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431570 [details].