Bug 222263 - Refactor OpenXR platform code into different classes and files.
Summary: Refactor OpenXR platform code into different classes and files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Imanol Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks: 208988 222173
  Show dependency tree / graph
 
Reported: 2021-02-22 02:23 PST by Imanol Fernandez
Modified: 2021-04-19 03:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (48.29 KB, patch)
2021-02-22 02:36 PST, Imanol Fernandez 		no flags Details | Formatted Diff | Diff
Patch (53.71 KB, patch)
2021-02-22 09:28 PST, Imanol Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Imanol Fernandez 2021-02-22 02:23:21 PST 
OpenXR port is going to grow with graphics, extensions, swapchains, controllers and more. We should split the code into different files to make it more readable and maintanable.
Comment 1 Imanol Fernandez 2021-02-22 02:36:16 PST 
Created attachment 421175 [details]
Patch
Comment 2 Sergio Villar Senin 2021-02-22 08:38:23 PST 
Comment on attachment 421175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421175&action=review

Looking great. Perhaps add also the new files to XCode

> Source/WebCore/ChangeLog:3


Super nit: OpenXR is not really a WebKit "port". It's just platform code.

> Source/WebCore/ChangeLog:8
> +        OpenXR port is going to grow with graphics, extensions, swapchains, controllers and more.

Ditto

> Source/WebCore/platform/xr/openxr/OpenXRExtensions.cpp:2
> + * Copyright (C) 2020 Igalia, S.L.

2021 :)

> Source/WebCore/platform/xr/openxr/OpenXRInstance.cpp:2
> + * Copyright (C) 2020 Igalia, S.L.

2021
Comment 3 Imanol Fernandez 2021-02-22 09:28:47 PST 
Created attachment 421201 [details]
Patch

Add files to Xcode and fix nits
Comment 4 EWS 2021-02-24 05:13:27 PST 
Committed r273382: <https://commits.webkit.org/r273382>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421201 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-24 05:14:14 PST 
<rdar://problem/74691123>