Bug 222173 – Implement OpenXR port graphics binding

• Status: RESOLVED
• Resolution: FIXED
• Component: WebXR

[Imanol Fernandez]

Headless session is not valid for tracking or rendering, and we need a graphics binding to create a non headless XrSession.

[Imanol Fernandez]

Created attachment 420972 [details]
Patch

[Imanol Fernandez]

Comment on attachment 420972 [details]
Patch

I splitted the file refactor into a different patch: https://bugs.webkit.org/show_bug.cgi?id=222263

I'll rebase this one when 222264 is merged

[Imanol Fernandez]

Created attachment 421405 [details]
Patch

Rebase onto main

[Imanol Fernandez]

Created attachment 421406 [details]
Patch

Fix nit in changelog

[Sergio Villar Senin]

Comment on attachment 421406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421406&action=review

> Source/WebCore/platform/xr/openxr/OpenXRExtensions.cpp:78
> +        reinterpret_cast<PFN_xrVoidFunction*>(&m_methods.xrGetOpenGLGraphicsRequirementsKHR));

Use a single line here

> Source/WebCore/platform/xr/openxr/OpenXRUtils.h:30
> +typedef __eglMustCastToProperFunctionPointerType (*PFNEGLGETPROCADDRESSPROC)(const char *proc);

Seems superweird having to add this.

Style wise the asterisk should go always next to the type, void *EGL -> void* EGL, char *... etc

> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:265
> +    return features;

So this is how we avoid having to create the session too early. nice! I should have researched a bit more about it.

[Imanol Fernandez]

Created attachment 421630 [details]
Patch for landing

Address review feedback

[EWS]

Committed r273549: <https://commits.webkit.org/r273549>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421630 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74785342>