Through code inspection found an array size bug in RegExpPrototype.cpp. Also found a compliance bug when populating the "groups" property for indices when there aren't any named groups. In that case "groups" should be undefined instead on non-existent.
<rdar://problem/74497629>
Created attachment 420915 [details] Patch
Comment on attachment 420915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420915&action=review r=me > Source/JavaScriptCore/runtime/RegExpMatchesArray.h:109 > + indicesArray->putDirect(vm, RegExpMatchesIndicesGroupsPropertyOffset, indicesGroups ? indicesGroups : jsUndefined()); Can you add a test for this change?
Comment on attachment 420915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420915&action=review > Source/JavaScriptCore/runtime/RegExpPrototype.cpp:165 > +typedef std::array<char, 7 + 1> FlagsString; // 6 different flags and a null character terminator. /6 different flags/7 different flags/
Created attachment 420993 [details] Added local versions of updated but unmarked test262 match-indices test
(In reply to Michael Saboff from comment #5) > Created attachment 420993 [details] > Added local versions of updated but unmarked test262 match-indices test That should be "Added local versions of updated but unmerged test262 match-indices tests."
Comment on attachment 420993 [details] Added local versions of updated but unmarked test262 match-indices test r=me
Committed r273160 (234355@main): <https://commits.webkit.org/234355@main>
*** Bug 222278 has been marked as a duplicate of this bug. ***