RESOLVED FIXED Bug 222149
Create SQLite skeleton implementation for PCM fraud prevention 
https://bugs.webkit.org/show_bug.cgi?id=222149
Summary Create SQLite skeleton implementation for PCM fraud prevention
Kate Cheney
Reported 2021-02-18 17:49:23 PST
Tracking the work to add support for PCM fraud prevention to a SQLite database.
Attachments
Patch (16.45 KB, patch)
2021-02-18 18:15 PST, Kate Cheney 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.50 KB, patch)
2021-02-18 18:36 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-18 17:50:09 PST
<rdar://problem/74502655>
Kate Cheney
Comment 2 2021-02-18 18:15:34 PST
Created attachment 420895 [details] Patch
Jiewen Tan
Comment 3 2021-02-18 18:23:14 PST
Comment on attachment 420895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420895&action=review LGTM, r=me. Thanks for making this patch. > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:2966 > + // FIXME: Store these in the attribution object once PCM fraud prevention is in place. You can refer to this radar: <rdar://problem/73582032>. > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:3017 > + // FIXME: Use real values from the attribution object once PCM fraud prevention is in place. You can refer to this radar: <rdar://problem/73582032>.
Kate Cheney
Comment 4 2021-02-18 18:36:22 PST
Created attachment 420898 [details] Patch
Kate Cheney
Comment 5 2021-02-18 18:37:25 PST
(In reply to Jiewen Tan from comment #3) > Comment on attachment 420895 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420895&action=review > > LGTM, r=me. Thanks for making this patch. > Thanks -- waiting on EWS before landing. > > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:2966 > > + // FIXME: Store these in the attribution object once PCM fraud prevention is in place. > > You can refer to this radar: <rdar://problem/73582032>. > Fixed! > > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:3017 > > + // FIXME: Use real values from the attribution object once PCM fraud prevention is in place. > > You can refer to this radar: <rdar://problem/73582032>. Ditto.
EWS
Comment 6 2021-02-19 01:30:45 PST
Committed r273134: <https://commits.webkit.org/r273134> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420898 [details].
Darin Adler
Comment 7 2021-02-19 13:15:02 PST
Comment on attachment 420898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420898&action=review > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:274 > +static const String unattributedPrivateClickMeasurementSchemaV1() The const on the return value here is not valuable. We should change these "static const String" to "static String".
Note You need to log in before you can comment on or make changes to this bug.