Bug 222149 - Create SQLite skeleton implementation for PCM fraud prevention
Summary: Create SQLite skeleton implementation for PCM fraud prevention
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks: 221291
  Show dependency tree / graph
 
Reported: 2021-02-18 17:49 PST by Kate Cheney
Modified: 2021-02-19 13:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (16.45 KB, patch)
2021-02-18 18:15 PST, Kate Cheney 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (16.50 KB, patch)
2021-02-18 18:36 PST, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-02-18 17:49:23 PST 
Tracking the work to add support for PCM fraud prevention to a SQLite database.
Comment 1 Radar WebKit Bug Importer 2021-02-18 17:50:09 PST 
<rdar://problem/74502655>
Comment 2 Kate Cheney 2021-02-18 18:15:34 PST 
Created attachment 420895 [details]
Patch
Comment 3 Jiewen Tan 2021-02-18 18:23:14 PST 
Comment on attachment 420895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420895&action=review

LGTM, r=me. Thanks for making this patch.

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:2966
> +    // FIXME: Store these in the attribution object once PCM fraud prevention is in place.

You can refer to this radar: <rdar://problem/73582032>.

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:3017
> +    // FIXME: Use real values from the attribution object once PCM fraud prevention is in place.

You can refer to this radar: <rdar://problem/73582032>.
Comment 4 Kate Cheney 2021-02-18 18:36:22 PST 
Created attachment 420898 [details]
Patch
Comment 5 Kate Cheney 2021-02-18 18:37:25 PST 
(In reply to Jiewen Tan from comment #3)
> Comment on attachment 420895 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420895&action=review
> 
> LGTM, r=me. Thanks for making this patch.
> 

Thanks -- waiting on EWS before landing.

> > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:2966
> > +    // FIXME: Store these in the attribution object once PCM fraud prevention is in place.
> 
> You can refer to this radar: <rdar://problem/73582032>.
> 

Fixed!

> > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:3017
> > +    // FIXME: Use real values from the attribution object once PCM fraud prevention is in place.
> 
> You can refer to this radar: <rdar://problem/73582032>.

Ditto.
Comment 6 EWS 2021-02-19 01:30:45 PST 
Committed r273134: <https://commits.webkit.org/r273134>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420898 [details].
Comment 7 Darin Adler 2021-02-19 13:15:02 PST 
Comment on attachment 420898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420898&action=review

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:274
> +static const String unattributedPrivateClickMeasurementSchemaV1()

The const on the return value here is not valuable. We should change these "static const String" to "static String".