Bug 222076 - PCM: Request signature for unlinkable token using attributionSourceNonce
Summary: PCM: Request signature for unlinkable token using attributionSourceNonce
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks: 221291
  Show dependency tree / graph
 
Reported: 2021-02-17 14:47 PST by John Wilander
Modified: 2021-02-18 15:28 PST (History)
8 users (show)

See Also:

Attachments
Patch (71.46 KB, patch)
2021-02-17 15:13 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (72.54 KB, patch)
2021-02-17 18:50 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (72.94 KB, patch)
2021-02-17 22:25 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (72.99 KB, patch)
2021-02-17 22:38 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2021-02-17 14:47:49 PST 
The attributionSourceNonce from the anchor tag should be transferred to the network process and used to initiate token signing from the source server.
Comment 1 John Wilander 2021-02-17 14:48:01 PST 
<rdar://73581651>
Comment 2 John Wilander 2021-02-17 15:13:40 PST 
Created attachment 420731 [details]
Patch
Comment 3 John Wilander 2021-02-17 18:50:06 PST 
Created attachment 420781 [details]
Patch
Comment 4 John Wilander 2021-02-17 18:50:46 PST 
Comment on attachment 420781 [details]
Patch

Fixed content extensions layout test failure (renamed TestRunner function).
Comment 5 John Wilander 2021-02-17 22:25:07 PST 
Created attachment 420798 [details]
Patch
Comment 6 John Wilander 2021-02-17 22:26:46 PST 
Comment on attachment 420798 [details]
Patch

Fixed a bad search+replace in the failing layout test send-attribution-conversion-request.html where the URL mistakingly ended with the new signToken.php instead of the correct, pre-existing conversionReport.php.
Comment 7 John Wilander 2021-02-17 22:38:38 PST 
Created attachment 420799 [details]
Patch
Comment 8 John Wilander 2021-02-17 22:39:35 PST 
Comment on attachment 420799 [details]
Patch

Rebased to see if I can get it to apply cleanly.
Comment 9 John Wilander 2021-02-18 08:36:12 PST 
Comment on attachment 420799 [details]
Patch

Thanks for the review, Chris!
Comment 10 EWS 2021-02-18 11:44:44 PST 
Committed r273088: <https://commits.webkit.org/r273088>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420799 [details].