Bug 221859 - [LayoutTests] Convert http/tests/svg convert PHP to Python
Summary: [LayoutTests] Convert http/tests/svg convert PHP to Python
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-12 16:39 PST by Chris Gambrell
Modified: 2021-02-15 10:00 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.85 KB, patch)
2021-02-12 16:51 PST, Chris Gambrell
no flags Details | Formatted Diff | Diff
Patch (3.44 KB, patch)
2021-02-15 08:23 PST, Chris Gambrell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gambrell 2021-02-12 16:39:47 PST
Replacing PHP with equivalent Python CGI scripts
Comment 1 Radar WebKit Bug Importer 2021-02-12 16:40:39 PST
<rdar://problem/74298062>
Comment 2 Chris Gambrell 2021-02-12 16:51:46 PST
Created attachment 420194 [details]
Patch
Comment 3 Jonathan Bedard 2021-02-12 17:06:37 PST
Comment on attachment 420194 [details]
Patch

Looks good, although the comment concerns me a bit given we know that Python is a little slower than PHP...passing EWS is probably sufficient to cover that, though.
Comment 4 Jonathan Bedard 2021-02-12 17:28:55 PST
Comment on attachment 420194 [details]
Patch

I will land this at some point over the weekend, I want to make sure we clear EWS before sending it through commit queue.
Comment 5 Chris Gambrell 2021-02-15 08:23:22 PST
Created attachment 420319 [details]
Patch
Comment 6 Jonathan Bedard 2021-02-15 08:39:11 PST
(In reply to Jonathan Bedard from comment #4)
> Comment on attachment 420194 [details]
> Patch
> 
> I will land this at some point over the weekend, I want to make sure we
> clear EWS before sending it through commit queue.

Following up on this: EWS revealed an imported file using one the removed PHP scripts, so we didn't land the change posted Friday.
Comment 7 EWS 2021-02-15 10:00:53 PST
Committed r272860: <https://commits.webkit.org/r272860>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420319 [details].