RESOLVED FIXED 221859
[LayoutTests] Convert http/tests/svg convert PHP to Python 
https://bugs.webkit.org/show_bug.cgi?id=221859
Summary [LayoutTests] Convert http/tests/svg convert PHP to Python
Chris Gambrell
Reported 2021-02-12 16:39:47 PST
Replacing PHP with equivalent Python CGI scripts
Attachments
Patch (2.85 KB, patch)
2021-02-12 16:51 PST, Chris Gambrell 		no flags
DetailsFormatted DiffDiff
Patch (3.44 KB, patch)
2021-02-15 08:23 PST, Chris Gambrell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-12 16:40:39 PST
<rdar://problem/74298062>
Chris Gambrell
Comment 2 2021-02-12 16:51:46 PST
Created attachment 420194 [details] Patch
Jonathan Bedard
Comment 3 2021-02-12 17:06:37 PST
Comment on attachment 420194 [details] Patch Looks good, although the comment concerns me a bit given we know that Python is a little slower than PHP...passing EWS is probably sufficient to cover that, though.
Jonathan Bedard
Comment 4 2021-02-12 17:28:55 PST
Comment on attachment 420194 [details] Patch I will land this at some point over the weekend, I want to make sure we clear EWS before sending it through commit queue.
Chris Gambrell
Comment 5 2021-02-15 08:23:22 PST
Created attachment 420319 [details] Patch
Jonathan Bedard
Comment 6 2021-02-15 08:39:11 PST
(In reply to Jonathan Bedard from comment #4) > Comment on attachment 420194 [details] > Patch > > I will land this at some point over the weekend, I want to make sure we > clear EWS before sending it through commit queue. Following up on this: EWS revealed an imported file using one the removed PHP scripts, so we didn't land the change posted Friday.
EWS
Comment 7 2021-02-15 10:00:53 PST
Committed r272860: <https://commits.webkit.org/r272860> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420319 [details].
Note You need to log in before you can comment on or make changes to this bug.