Bug 221756 - JSC EWSes should be triggered by change in any jsc file
Summary: JSC EWSes should be triggered by change in any jsc file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-11 08:51 PST by Aakash Jain
Modified: 2021-02-11 10:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.46 KB, patch)
2021-02-11 08:56 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-02-11 08:51:56 PST 
JSC EWSes should be triggered by change in any jsc file. It wasn't triggered on https://bugs.webkit.org/show_bug.cgi?id=221726 which changed Source/cmake/OptionsJSCOnly.cmake
Comment 1 Aakash Jain 2021-02-11 08:56:53 PST 
Created attachment 419995 [details]
Patch
Comment 2 Jonathan Bedard 2021-02-11 09:03:57 PST 
Comment on attachment 419995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419995&action=review

> Tools/CISupport/ews-build/steps.py:-338
> -        'Source/JavaScriptCore/',

Are the regexes not case-sensitive?
Comment 3 Aakash Jain 2021-02-11 09:21:32 PST 
(In reply to Jonathan Bedard from comment #2)
> Are the regexes not case-sensitive?
Nope, we use re.IGNORECASE in re.search()
Comment 4 EWS 2021-02-11 10:50:45 PST 
Committed r272738: <https://commits.webkit.org/r272738>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419995 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-11 10:51:13 PST 
<rdar://problem/74241656>