Bug 221726 - [CMake] Enable hidden visibility on JSCOnly
Summary: [CMake] Enable hidden visibility on JSCOnly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-10 16:15 PST by Don Olmstead
Modified: 2021-02-10 18:22 PST (History)
11 users (show)

See Also:


Attachments
Patch (1.96 KB, patch)
2021-02-10 16:29 PST, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch + a jsc.cpp modification to prevent EWS ignoring (1.67 KB, patch)
2021-02-10 16:40 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-02-10 16:15:15 PST
...
Comment 1 Don Olmstead 2021-02-10 16:29:51 PST
Created attachment 419920 [details]
Patch
Comment 2 Don Olmstead 2021-02-10 16:40:00 PST
Created attachment 419921 [details]
Patch + a jsc.cpp modification to prevent EWS ignoring

The EWS for JSCOnly builds ignored the actual patch so modifying a file to make them not skip a build.
Comment 3 Yusuke Suzuki 2021-02-10 17:29:33 PST
Comment on attachment 419920 [details]
Patch

r=me
Comment 4 EWS 2021-02-10 18:22:28 PST
Committed r272699: <https://commits.webkit.org/r272699>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419920 [details].