Bug 221737 - [LayoutTests] Convert http/tests/mime convert PHP to Python
Summary: [LayoutTests] Convert http/tests/mime convert PHP to Python
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-10 19:55 PST by Chris Gambrell
Modified: 2021-02-12 17:48 PST (History)
6 users (show)

See Also:

Attachments
Patch (14.96 KB, patch)
2021-02-12 08:02 PST, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Patch (14.98 KB, patch)
2021-02-12 15:20 PST, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gambrell 2021-02-10 19:55:50 PST 
Replacing PHP with equivalent Python CGI scripts
Comment 1 Radar WebKit Bug Importer 2021-02-10 19:56:57 PST 
<rdar://problem/74219024>
Comment 2 Chris Gambrell 2021-02-12 08:02:41 PST 
Created attachment 420123 [details]
Patch
Comment 3 Jonathan Bedard 2021-02-12 09:02:25 PST 
Comment on attachment 420123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420123&action=review

> LayoutTests/http/tests/mime/quoted-charset.py:7
> +print('<p>Should say SUCCESS: SUóóåSS</p>')

Should be a multi-line string. Also, you may need to dump this first sequence as bytes since this is testing a non-standard charset.

> LayoutTests/http/tests/mime/resources/uppercase-mime-type.py:7
> +print('<html>')

Should use a multi-line string here.
Comment 4 Chris Gambrell 2021-02-12 15:20:04 PST 
Created attachment 420185 [details]
Patch
Comment 5 Jonathan Bedard 2021-02-12 16:59:40 PST 
Comment on attachment 420185 [details]
Patch

wk1 and wk2 tests are passing!
Comment 6 EWS 2021-02-12 17:48:28 PST 
Committed r272827: <https://commits.webkit.org/r272827>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420185 [details].