Bug 221557 – JSC stress test stress/copy-data-properties-fast-path.js.default fails on s390x and ppc64le

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Catanzaro]

This new test from bug #221454 is broken on s390x and ppc64le, but works on x86_64 and aarch64. This is a little odd since these architectures have little in common. All architectures have JIT disabled and cloop enabled. The test is:

//@ runDefault("--slowPathAllocsBetweenGCs=4", "--watchdog=100", "--watchdog-exception-ok")

function foo() {
  let { ...r } = { xx:0 };
  foo();
}
foo();

How is that recursion supposed to end? Anyway, on these architectures it doesn't, the error is:

stress/copy-data-properties-fast-path.js.default: Exception: RangeError: Maximum call stack size exceeded.
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: [e-mail]:5:6
stress/copy-data-properties-fast-path.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/copy-data-properties-fast-path.js.default

[Michael Catanzaro]

Created attachment 419987 [details]
Patch

[Saam Barati]

Comment on attachment 419987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419987&action=review

> JSTests/ChangeLog:8
> +        Skip the test on these architectures. I don't know what else to do with it.

how are they failing? Maybe worth a bug to figure it out on your end?

[Michael Catanzaro]

(In reply to Saam Barati from comment #2)
> Comment on attachment 419987 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419987&action=review
> 
> > JSTests/ChangeLog:8
> > +        Skip the test on these architectures. I don't know what else to do with it.
> 
> how are they failing?

The failure is in comment #0: the test just keeps recursing forever.

> Maybe worth a bug to figure it out on your end?

Well, I think this is that bug? :P I don't think we'll figure it out without guidance from JSC developers. The best I can do is usually a bisect, but in this case it's a new test so there's nothing to bisect. I'm happy to try checking code changes on the affected machines if that would be helpful, but I wouldn't know where to start.

[EWS]

Committed r272833: <https://commits.webkit.org/r272833>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419987 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74311603>

[Michael Catanzaro]

...

[Yusuke Suzuki]

Ah! I landed the fix in https://bugs.webkit.org/show_bug.cgi?id=221668#c8 when working on https://bugs.webkit.org/show_bug.cgi?id=221668 :)

[Michael Catanzaro]

Ah... so I should unskip the test, then?

[Michael Catanzaro]

Let's try that.

[Michael Catanzaro]

Created attachment 420241 [details]
Patch for landing

[EWS]

Committed r272840: <https://commits.webkit.org/r272840>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420241 [details].