Bug 221454 - [JSC] globalFuncCopyDataProperties should not perform GC-sensitive operation in the middle of Structure::forEachProperty
Summary: [JSC] globalFuncCopyDataProperties should not perform GC-sensitive operation ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-05 01:17 PST by Yusuke Suzuki
Modified: 2021-02-08 09:09 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.47 KB, patch)
2021-02-05 01:18 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (4.30 KB, patch)
2021-02-05 01:30 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2021-02-05 01:31 PST, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-02-05 01:17:24 PST
[JSC] globalFuncCopyDataProperties should not perform GC-sesitive operation in the middle of Structure::forEachProperty
Comment 1 Yusuke Suzuki 2021-02-05 01:18:45 PST
Created attachment 419370 [details]
Patch
Comment 2 Yusuke Suzuki 2021-02-05 01:30:12 PST
Created attachment 419371 [details]
Patch
Comment 3 Yusuke Suzuki 2021-02-05 01:31:13 PST
Created attachment 419372 [details]
Patch
Comment 4 Yusuke Suzuki 2021-02-05 01:32:14 PST
<rdar://problem/73974480>
Comment 5 Mark Lam 2021-02-05 10:32:09 PST
Comment on attachment 419372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419372&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] globalFuncCopyDataProperties should not perform GC-sesitive operation in the middle of Structure::forEachProperty

/sesitive/sensitive/
Comment 6 Yusuke Suzuki 2021-02-05 10:55:23 PST
Comment on attachment 419372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419372&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        [JSC] globalFuncCopyDataProperties should not perform GC-sesitive operation in the middle of Structure::forEachProperty
> 
> /sesitive/sensitive/

Fixed!
Comment 7 Yusuke Suzuki 2021-02-05 10:58:12 PST
Committed r272428: <https://trac.webkit.org/changeset/272428>
Comment 8 Yusuke Suzuki 2021-02-05 11:08:45 PST
Committed r272430: <https://trac.webkit.org/changeset/272430>