Bug 221523 - REGRESSION(r272379) [WPE] imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant tests are Image Failing
Summary: REGRESSION(r272379) [WPE] imported/w3c/web-platform-tests/mathml/relations/cs...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-06 17:59 PST by Lauro Moura
Modified: 2021-03-04 11:11 PST (History)
4 users (show)

See Also:

Attachments
Tentative fix (5.52 KB, patch)
2021-02-06 18:12 PST, Lauro Moura 		aperez: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-02-06 17:59:17 PST 
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-initial.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-looped.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-monospace.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-script.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-stretched.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-tailed.html

In the tests listed above, the 0 glyph is always drawn.

Changing the guard added by r272379 to `#if (!PLATFORM(COCOA) && !USE(GLIB)) || USE(CTFONTSHAPEGLYPHS)` seems to fix the issue, although the original test added (fast/text/multi-code-unit-simple-path.html) keeps failing for GTK/WPE. It keeps telling a reference mismatch did not happen, despite the test on Minibrowser showing the char box.
Comment 1 Lauro Moura 2021-02-06 18:12:51 PST 
Created attachment 419517 [details]
Tentative fix
Comment 2 EWS 2021-02-07 04:57:17 PST 
commit-queue failed to commit attachment 419517 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 3 Lauro Moura 2021-02-07 20:18:10 PST 
Committed r272479: <https://trac.webkit.org/changeset/272479>
Comment 4 Radar WebKit Bug Importer 2021-02-07 20:19:13 PST 
<rdar://problem/74082393>