Bug 221356 – Supplementary code points (U+10000 - U+10FFFF) are not shaped correctly in the fast text codepath

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Supplementary code points (U+10000 - U+10FFFF) are not shaped correctly in the fast text codepath

[Myles C. Maxfield]

Created attachment 419182 [details]
Needs test

[Myles C. Maxfield]

<rdar://problem/72555297>

[Myles C. Maxfield]

Created attachment 419196 [details]
Patch

[Myles C. Maxfield]

Created attachment 419198 [details]
Patch

[EWS]

Found 18 new test failures: fast/text/complex-small-caps-non-bmp-capitalize.html, fast/text/multiple-codeunit-vertical-upright-2.html, fast/text/multiple-codeunit-vertical-upright.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-initial.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-looped.html ...

[Myles C. Maxfield]

Created attachment 419223 [details]
Patch for committing

[Darin Adler]

Comment on attachment 419198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419198&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:265
> +        if (character >= 0x10000)

I think it would be more elegant if this used U_IS_SUPPLEMENTARY or !U_IS_BMP. Not really sure how much we want to lean into using the semantically more clear macros over the mechanically more clear numeric comparisons.

[Darin Adler]

Comment on attachment 419198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419198&action=review

>> Source/WebCore/platform/graphics/WidthIterator.cpp:265
>> +        if (character >= 0x10000)
> 
> I think it would be more elegant if this used U_IS_SUPPLEMENTARY or !U_IS_BMP. Not really sure how much we want to lean into using the semantically more clear macros over the mechanically more clear numeric comparisons.

Or maybe this should be checking advanceLength or clusterLength (they are the same, why do we have both?) instead of character?

[Myles C. Maxfield]

(In reply to Darin Adler from comment #7)
> Comment on attachment 419198 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419198&action=review
> 
> > Source/WebCore/platform/graphics/WidthIterator.cpp:265
> > +        if (character >= 0x10000)
> 
> I think it would be more elegant if this used U_IS_SUPPLEMENTARY or
> !U_IS_BMP. Not really sure how much we want to lean into using the
> semantically more clear macros over the mechanically more clear numeric
> comparisons.

I actually already did this in the patch for committing :)

[Darin Adler]

(In reply to Myles C. Maxfield from comment #9)
> I actually already did this in the patch for committing :)

Excellent!

[EWS]

Committed r272379: <https://trac.webkit.org/changeset/272379>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419223 [details].