Bug 221481 - [Interop 2021][css-flexbox] Ignore specified block sizes when computing flex items' intrinsic block sizes
Summary: [Interop 2021][css-flexbox] Ignore specified block sizes when computing flex ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 136754
  Show dependency treegraph
 
Reported: 2021-02-05 09:32 PST by Sergio Villar Senin
Modified: 2022-05-31 10:45 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2021-02-05 09:32:31 PST
Newly imported WPT tests are failing:

imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-002a.html
imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-002c.html
imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-width-auto-002a.html
imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-width-auto-002c.html
imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-026.html
imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-029.html
imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-015.html
Comment 1 Sergio Villar Senin 2021-02-11 07:54:36 PST
(In reply to Sergio Villar Senin from comment #0)
> Newly imported WPT tests are failing:
> 
> imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-002a.
> html
> imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-height-auto-002c.
> html
> imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-width-auto-002a.
> html
> imported/w3c/web-platform-tests/css/css-flexbox/flexbox-min-width-auto-002c.
> html

These will be fixed as part of bug 221110
Comment 2 Radar WebKit Bug Importer 2021-02-12 09:33:12 PST
<rdar://problem/74279472>
Comment 3 Sergio Villar Senin 2021-03-01 07:37:19 PST
> imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-026.html
> imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-029.html
> imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-015.html

All these 3 fail for the very same reason. Let's suppose the following scenario:

    <div style="display: flex; flex-direction: column">
      <div style="flex-basis: 100px; height: 200px">
        <div style="height: 100%">

When computing the flex item intrinsic block size we let the inner div's height resolve against the flex item's 200px, giving the flex item an automatic minimum size of 200px, even though the min-content size is supposed to be calculated with the item having an 'auto' size. We should ignore the item's 200px height instead.

Blink fixed it in NG in https://chromium-review.googlesource.com/c/chromium/src/+/2640774
Comment 4 Brent Fulgham 2022-05-31 10:44:46 PDT
Also these:

imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-013.html
imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-025.html