Bug 221476 - [ews] commit-queue should use commits.webkit.org url instead of trac url
Summary: [ews] commit-queue should use commits.webkit.org url instead of trac url
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2021-02-05 09:23 PST by Aakash Jain
Modified: 2021-02-06 16:08 PST (History)
5 users (show)

See Also:

Patch (2.18 KB, patch)
2021-02-05 09:24 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-02-05 09:23:03 PST
commit-queue should use commits.webkit.org url instead of trac url. commits.webkit.org is a redirection service, which currently redirects to trac, but will start redirecting to github in future. When we switch commits.webkit.org to redirect to github, all old commits.webkit.org urls would redirect to github appropriately.
Comment 1 Aakash Jain 2021-02-05 09:24:57 PST
Created attachment 419417 [details]
Comment 2 Jonathan Bedard 2021-02-05 10:10:12 PST
Comment on attachment 419417 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=419417&action=review

> Tools/CISupport/ews-build/steps.py:3109
> +        return 'https://commits.webkit.org/r{}'.format(revision)

I think we should use identifiers here, but this is good step in the right direction, so I'm going to r+ it.
Comment 3 EWS 2021-02-05 10:31:51 PST
Committed r272423: <https://trac.webkit.org/changeset/272423>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419417 [details].
Comment 4 Radar WebKit Bug Importer 2021-02-05 10:32:30 PST
Comment 5 Aakash Jain 2021-02-06 06:08:44 PST
Restarted buildbot to pick up this change.
Comment 6 Aakash Jain 2021-02-06 16:08:54 PST
Working fine, e.g.: https://bugs.webkit.org/show_bug.cgi?id=221502#c4