Bug 221502 - [LFC][IFC] Continuation pre and post block inline boxes should not have both the start and end decorations of the original inline box
Summary: [LFC][IFC] Continuation pre and post block inline boxes should not have both ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-05 14:25 PST by zalan
Modified: 2021-02-10 14:38 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.29 KB, patch)
2021-02-05 14:43 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (6.23 KB, patch)
2021-02-06 08:02 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-02-05 14:25:41 PST
<span style="margin-left: 10px;><div></div></span>
the inline box inside the post block should not have left margin.
Comment 1 zalan 2021-02-05 14:43:12 PST
Created attachment 419467 [details]
Patch
Comment 2 Antti Koivisto 2021-02-06 07:16:55 PST
Comment on attachment 419467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419467&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:88
> +            if (!childRenderer.parent()->isAnonymousBlock())
> +                return makeUnique<Layout::ContainerBox>(Layout::Box::ElementAttributes { Layout::Box::ElementType::GenericElement }, WTFMove(style));

I'd just revert the condition and use the makeUnique at the end in all cases.
Comment 3 zalan 2021-02-06 08:02:02 PST
Created attachment 419502 [details]
Patch
Comment 4 EWS 2021-02-06 10:01:32 PST
Committed r272463: <https://commits.webkit.org/r272463>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419502 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-10 14:38:24 PST
<rdar://problem/74206895>