Bug 221405 - Improve percentage height in shouldComputeLogicalWidthFromAspectRatio
Summary: Improve percentage height in shouldComputeLogicalWidthFromAspectRatio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks: 47738
  Show dependency tree / graph
 
Reported: 2021-02-04 06:32 PST by Rob Buis
Modified: 2021-02-17 02:38 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2021-02-04 06:33 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (4.55 KB, patch)
2021-02-05 13:24 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (4.59 KB, patch)
2021-02-17 01:11 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2021-02-04 06:32:30 PST 
Make shouldComputeLogicalWidthFromAspectRatio check percentage height better.
Comment 1 Rob Buis 2021-02-04 06:33:51 PST 
Created attachment 419278 [details]
Patch
Comment 2 Rob Buis 2021-02-05 13:24:24 PST 
Created attachment 419454 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-02-11 06:33:17 PST 
<rdar://problem/74232105>
Comment 4 Simon Fraser (smfr) 2021-02-16 14:49:52 PST 
Comment on attachment 419454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419454&action=review

> Source/WebCore/rendering/RenderBox.cpp:5092
> +    if (!shouldComputeLogicalWidthFromAspectRatioAndInsets() && !style().logicalHeight().isFixed() && !(style().logicalHeight().isPercentOrCalculated() && (isOutOfFlowPositioned() || percentageLogicalHeightIsResolvable())))

That list of conditions is getting pretty complex. Maybe wrap it in a lambda for clarity.
Comment 5 Rob Buis 2021-02-17 01:11:29 PST 
Created attachment 420613 [details]
Patch
Comment 6 EWS 2021-02-17 02:38:00 PST 
Committed r272992: <https://commits.webkit.org/r272992>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420613 [details].