Bug 221400 - [MacOS] Enable Audio Capture in GPUProcess by default
Summary: [MacOS] Enable Audio Capture in GPUProcess by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 221457
Blocks:
  Show dependency tree / graph
 
Reported: 2021-02-04 04:23 PST by youenn fablet
Modified: 2021-02-11 09:30 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2021-02-04 04:25 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.88 KB, patch)
2021-02-05 02:46 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.90 KB, patch)
2021-02-08 09:10 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (5.28 KB, patch)
2021-02-11 02:22 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-02-04 04:23:30 PST 
[MacOS] Enable Audio Capture in GPUProcess by default
Comment 1 youenn fablet 2021-02-04 04:25:11 PST 
Created attachment 419270 [details]
Patch
Comment 2 youenn fablet 2021-02-05 02:46:26 PST 
Created attachment 419382 [details]
Patch
Comment 3 youenn fablet 2021-02-05 05:07:39 PST 
Comment on attachment 419382 [details]
Patch

Mac API test failures are handled in https://bugs.webkit.org/show_bug.cgi?id=221457
Comment 4 youenn fablet 2021-02-08 09:10:17 PST 
Created attachment 419597 [details]
Patch
Comment 5 EWS 2021-02-08 12:22:26 PST 
Committed r272507: <https://commits.webkit.org/r272507>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419597 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-10 13:55:43 PST 
<rdar://problem/74204806>
Comment 7 Ryan Haddad 2021-02-10 14:36:06 PST 
Reverted r272507 for reason:

Caused TestWebKitAPI.WebKit.OnDeviceChangeCrash to become a flaky timeout

Committed r272686: <https://trac.webkit.org/changeset/272686>
Comment 8 youenn fablet 2021-02-11 02:22:25 PST 
Created attachment 419967 [details]
Patch
Comment 9 youenn fablet 2021-02-11 03:01:53 PST 
Comment on attachment 419967 [details]
Patch

Putting r? again since I changed the patch to fix the issue of clearing the granted requests before adding the previously granted request.
Comment 10 EWS 2021-02-11 09:30:40 PST 
Committed r272735: <https://commits.webkit.org/r272735>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419967 [details].