Bug 221346 – REGRESSION (270392): Launch time regression under IOSurface::maximumSize()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

REGRESSION (270392): Launch time regression under IOSurface::maximumSize()

[Tim Horton]

Created attachment 419160 [details]
Patch

[Tim Horton]

<rdar://problem/73507706>

[Sam Weinig]

Comment on attachment 419160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419160&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:477
> +        parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize();

Does it have a reasonable default value so that if something in the WebProcess (and GPU process is not enabled for DOM) tries to read this it won't be garbage?

[Tim Horton]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 419160 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419160&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:477
> > +        parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize();
> 
> Does it have a reasonable default value so that if something in the
> WebProcess (and GPU process is not enabled for DOM) tries to read this it
> won't be garbage?

The WebProcess will compute it if it's still 0x0 the first time it's read.

[Tim Horton]

(And, to be clear, IntSize is 0x0 by default)

[EWS]

Committed r272335: <https://trac.webkit.org/changeset/272335>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419160 [details].

[Ryan Haddad]

There was a follow up for this change: https://trac.webkit.org/changeset/272355/webkit