Bug 221346 - REGRESSION (270392): Launch time regression under IOSurface::maximumSize()
Summary: REGRESSION (270392): Launch time regression under IOSurface::maximumSize()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-03 11:18 PST by Tim Horton
Modified: 2022-01-26 14:02 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2021-02-03 11:21 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-02-03 11:18:10 PST 
REGRESSION (270392): Launch time regression under IOSurface::maximumSize()
Comment 1 Tim Horton 2021-02-03 11:21:02 PST 
Created attachment 419160 [details]
Patch
Comment 2 Tim Horton 2021-02-03 11:21:05 PST 
<rdar://problem/73507706>
Comment 3 Sam Weinig 2021-02-03 11:47:11 PST 
Comment on attachment 419160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419160&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:477
> +        parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize();

Does it have a reasonable default value so that if something in the WebProcess (and GPU process is not enabled for DOM) tries to read this it won't be garbage?
Comment 4 Tim Horton 2021-02-03 11:48:00 PST 
(In reply to Sam Weinig from comment #3)
> Comment on attachment 419160 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419160&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:477
> > +        parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize();
> 
> Does it have a reasonable default value so that if something in the
> WebProcess (and GPU process is not enabled for DOM) tries to read this it
> won't be garbage?

The WebProcess will compute it if it's still 0x0 the first time it's read.
Comment 5 Tim Horton 2021-02-03 11:51:08 PST 
(And, to be clear, IntSize is 0x0 by default)
Comment 6 EWS 2021-02-03 12:32:27 PST 
Committed r272335: <https://trac.webkit.org/changeset/272335>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419160 [details].
Comment 7 Ryan Haddad 2021-02-11 16:15:45 PST 
There was a follow up for this change: https://trac.webkit.org/changeset/272355/webkit