Bug 219484 - GPU Process: Sandbox violations under IOSurface::maximumSize in the Web Content process
Summary: GPU Process: Sandbox violations under IOSurface::maximumSize in the Web Conte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-03 00:59 PST by Tim Horton
Modified: 2022-01-26 14:02 PST (History)
6 users (show)

See Also:

Attachments
Patch (8.61 KB, patch)
2020-12-03 01:00 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.63 KB, patch)
2020-12-03 02:28 PST, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-12-03 00:59:32 PST 
GPU Process: Sandbox violations under IOSurface::maximumSize in the Web Content process
Comment 1 Tim Horton 2020-12-03 01:00:35 PST 
Created attachment 415282 [details]
Patch
Comment 2 Tim Horton 2020-12-03 01:00:38 PST 
<rdar://problem/71603808>
Comment 3 Ryosuke Niwa 2020-12-03 02:05:22 PST 
Comment on attachment 415282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415282&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:248
> +    static WTF::Optional<IntSize> maximumSize;
> +    return maximumSize;

Can we assert that this is only called in the main thread?
Comment 4 Tim Horton 2020-12-03 02:28:15 PST 
Created attachment 415287 [details]
Patch
Comment 5 EWS 2020-12-03 03:10:16 PST 
Committed r270392: <https://trac.webkit.org/changeset/270392>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415287 [details].
Comment 6 Alexey Proskuryakov 2020-12-03 07:40:24 PST 
Comment on attachment 415287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415287&action=review

> Source/WebKit/ChangeLog:17
> +        Fetch the maximum allowed size of an IOSurface on the current hardware

It will never change when switching between integrated and discrete?
Comment 7 Tim Horton 2020-12-03 07:52:34 PST 
I hope not, since we don’t recreate all existing surfaces when that happens. But it’s a good point.