Bug 221328 – Make shouldComputeLogicalWidthFromAspectRatioAndInsets writing mode aware

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rob Buis]

Commit r271061 added support for aspect-ratio on positioned elements, taking into account
insets, but it failed to take writing-mode into account when checking insets. This change fixes
that by asking logical values.

[Rob Buis]

Created attachment 419128 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 419128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419128&action=review

r=me, with a nit comment inline.

> Source/WebCore/rendering/RenderBox.cpp:5100
> +    if (style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto()))

What about logicalWidth() instead of width()? I guess it doesn't really matter as we have an and for width and height, but maybe it'd be worth changing for consistency dunno.

[Rob Buis]

Comment on attachment 419128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419128&action=review

>> Source/WebCore/rendering/RenderBox.cpp:5100
>> +    if (style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto()))
> 
> What about logicalWidth() instead of width()? I guess it doesn't really matter as we have an and for width and height, but maybe it'd be worth changing for consistency dunno.

Interesting idea, but ultimately we need to check both dimensions and using the logical variants is a bit slower. So I'll keep as-is.

[EWS]

Committed r272363: <https://trac.webkit.org/changeset/272363>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419128 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73970893>