Bug 221280 - [build.webkit.org] Update dashboard links for layout test results
Summary: [build.webkit.org] Update dashboard links for layout test results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency tree / graph
 
Reported: 2021-02-02 12:15 PST by Aakash Jain
Modified: 2021-02-12 10:10 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2021-02-03 07:44 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Patch (3.66 KB, patch)
2021-02-04 14:39 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-02-02 12:15:06 PST 
In https://trac.webkit.org/r271801, we stopped hosting results on build.webkit.org (upcoming instance). Instead we are hosting results on S3. We should update dashboard to fetch the results from S3.
Comment 1 Aakash Jain 2021-02-03 07:44:03 PST 
Created attachment 419136 [details]
Patch
Comment 2 Jonathan Bedard 2021-02-03 11:49:34 PST 
Comment on attachment 419136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419136&action=review

> Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:200
> +            url = this.baseURLForResults;

This doesn't look right. `options && options.baseURLForResults` should resolve to a boolean
Comment 3 Jonathan Bedard 2021-02-03 13:59:35 PST 
Comment on attachment 419136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419136&action=review

>> Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:200
>> +            url = this.baseURLForResults;
> 
> This doesn't look right. `options && options.baseURLForResults` should resolve to a boolean

Ok, I see what we're doing here, but I'm not sure this is the clearest way to express this. Can we change `this.baseURLForResults = options && options.baseURLForResults` to `this.baseURLForResults = options ? options.baseURLForResults : null`
Comment 4 Aakash Jain 2021-02-04 14:39:33 PST 
Created attachment 419325 [details]
Patch
Comment 5 EWS 2021-02-04 15:47:13 PST 
commit-queue failed to commit attachment 419325 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 6 EWS 2021-02-04 16:55:13 PST 
Committed r272399: <https://trac.webkit.org/changeset/272399>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419325 [details].
Comment 7 Radar WebKit Bug Importer 2021-02-04 16:56:13 PST 
<rdar://problem/74003748>