Bug 221058 - [iOS] add accessibility image extraction contextmenu item for revealing images
Summary: [iOS] add accessibility image extraction contextmenu item for revealing images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-27 14:09 PST by Devin Rousso
Modified: 2021-01-27 17:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (10.37 KB, patch)
2021-01-27 14:33 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (9.40 KB, patch)
2021-01-27 15:23 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (14.58 KB, patch)
2021-01-27 15:51 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-01-27 14:09:11 PST 
.
Comment 1 Devin Rousso 2021-01-27 14:14:41 PST 
<rdar://problem/73382220>
Comment 2 Devin Rousso 2021-01-27 14:33:14 PST 
Created attachment 418583 [details]
Patch
Comment 3 Wenson Hsieh 2021-01-27 14:41:18 PST 
Comment on attachment 418583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418583&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKElementActionInternal.h:41
> +#if ENABLE(IMAGE_EXTRACTION)
> ++ (UIImage *)imageForElementActionTypeImageExtraction;
> ++ (UIImage *)imageForElementActionTypeRevealImage;
> +#endif

Since these methods are only used inside _WKElementAction.mm, you don't need to declare them in this internal header as well.
Comment 4 Devin Rousso 2021-01-27 15:23:06 PST 
Created attachment 418589 [details]
Patch
Comment 5 Devin Rousso 2021-01-27 15:51:33 PST 
Created attachment 418593 [details]
Patch
Comment 6 EWS 2021-01-27 17:11:50 PST 
Committed r271991: <https://trac.webkit.org/changeset/271991>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418593 [details].