Bug 219524 - [iOS] Provide a context menu action to perform accessibility image extraction
Summary: [iOS] Provide a context menu action to perform accessibility image extraction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-03 18:53 PST by Devin Rousso
Modified: 2021-01-27 14:09 PST (History)
7 users (show)

See Also:

Attachments
Patch (8.67 KB, patch)
2020-12-03 19:02 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (8.66 KB, patch)
2020-12-04 10:24 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-12-03 18:53:56 PST 
<rdar://problem/69969613>
Comment 1 Devin Rousso 2020-12-03 19:02:11 PST 
Created attachment 415375 [details]
Patch
Comment 2 Wenson Hsieh 2020-12-04 08:05:25 PST 
Comment on attachment 415375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415375&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:76
> +- (void)actionSheetAssistant:(WKActionSheetAssistant *)assistant imageExtraction:(UIImage *)image;

Nit - this is a bit of a funny name for a delegate method. Usually, it's either a noun (if the delegate returns something), like `- (Foo *)instance:fooForPurpose:`, or it's a verb, like `- (void)instance:doFoo:`. Maybe this should be something along the lines of `-actionSheetAssistant:extractImage:` or `-actionSheetAssistant:handleImageExtraction:`.
Comment 3 Devin Rousso 2020-12-04 10:24:57 PST 
Created attachment 415426 [details]
Patch
Comment 4 EWS 2020-12-04 10:57:14 PST 
Committed r270436: <https://trac.webkit.org/changeset/270436>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415426 [details].