Bug 220890 - [WASM-References] Enable reference types by default
Summary: [WASM-References] Enable reference types by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-23 03:26 PST by Dmitry
Modified: 2021-01-29 15:15 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.29 KB, patch)
2021-01-23 03:28 PST, Dmitry
no flags Details | Formatted Diff | Diff
Patch (10.04 KB, patch)
2021-01-24 23:19 PST, Dmitry
no flags Details | Formatted Diff | Diff
Patch (10.15 KB, patch)
2021-01-25 02:52 PST, Dmitry
no flags Details | Formatted Diff | Diff
Patch (9.93 KB, patch)
2021-01-29 03:21 PST, Dmitry
no flags Details | Formatted Diff | Diff
Patch (9.37 KB, patch)
2021-01-29 06:07 PST, Dmitry
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry 2021-01-23 03:26:58 PST
[WASM-References] Enable reference types by default
Comment 1 Dmitry 2021-01-23 03:28:45 PST
Created attachment 418222 [details]
Patch
Comment 2 Yusuke Suzuki 2021-01-23 22:58:26 PST
I was worrying about whether enabling Wasm-references disables a lot of important tests in WPT because of early failures, but it looks like it is not. Some wrong WPT tests are failed, but its failure scope is limited to these wrong tests. And other important tests are still working correctly.
So, I think, enabling these flags and rebaselining these tests with the new expect files are the path.
Comment 3 Yusuke Suzuki 2021-01-23 23:00:08 PST
Can you also investigate these failures and ensure they are because of wrong tests?
Comment 4 Dmitry 2021-01-24 23:19:59 PST
Created attachment 418253 [details]
Patch
Comment 5 Yusuke Suzuki 2021-01-25 02:47:16 PST
Looks like EWS is failing. Can you rebaseline the expect files?
Comment 6 Dmitry 2021-01-25 02:52:14 PST
Created attachment 418269 [details]
Patch
Comment 7 Yusuke Suzuki 2021-01-25 03:09:26 PST
Comment on attachment 418269 [details]
Patch

r=me is EWS gets green. If EWS gets red, please fix :)
Comment 8 Yusuke Suzuki 2021-01-25 03:12:56 PST
Comment on attachment 418269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418269&action=review

Ah, wait. Sorry, can you check the potential issue?

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any-expected.txt:3
> +FAIL Arguments for externref table set assert_equals: expected (undefined) undefined but got (object) null

Can you explain the reason of this failure?
Comment 9 Yusuke Suzuki 2021-01-25 15:12:34 PST
Comment on attachment 418269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418269&action=review

>> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any-expected.txt:3
>> +FAIL Arguments for externref table set assert_equals: expected (undefined) undefined but got (object) null
> 
> Can you explain the reason of this failure?

Talked with Dmitry at Slack. This is a real bug. This will be fixed in https://bugs.webkit.org/show_bug.cgi?id=220918, and this patch will be updated.
Comment 10 Dmitry 2021-01-29 03:21:10 PST
Created attachment 418716 [details]
Patch
Comment 11 Dmitry 2021-01-29 06:07:40 PST
Created attachment 418719 [details]
Patch
Comment 12 Yusuke Suzuki 2021-01-29 11:25:00 PST
Comment on attachment 418719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418719&action=review

r=me if EWS gets green

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor.any-expected.txt:25
> +FAIL Stray argument WebAssembly.Table.prototype.constructor expects the second argument to be null or an instance of WebAssembly.Function

OK, this is because WebAssembly tests in WPT is obsolete after wasm-reference-types.

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor.any.worker-expected.txt:25
> +FAIL Stray argument WebAssembly.Table.prototype.constructor expects the second argument to be null or an instance of WebAssembly.Function

OK, this is because WebAssembly tests in WPT is obsolete after wasm-reference-types.

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/get-set.any-expected.txt:4
> +FAIL Missing arguments: set assert_throws_js: function "() => table.set(0)" did not throw

OK, this is because WebAssembly tests in WPT is obsolete after wasm-reference-types.

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/get-set.any.worker-expected.txt:4
> +FAIL Missing arguments: set assert_throws_js: function "() => table.set(0)" did not throw

OK, this is because WebAssembly tests in WPT is obsolete after wasm-reference-types.
Comment 13 Yusuke Suzuki 2021-01-29 12:31:49 PST
accessibility/mac/test.mp3/root.xml
accessibility/mac/test.mp3/boot.xml
are failing these days. Ignore them.
Comment 14 EWS 2021-01-29 12:59:41 PST
Committed r272074: <https://trac.webkit.org/changeset/272074>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418719 [details].
Comment 15 Radar WebKit Bug Importer 2021-01-29 13:01:30 PST
<rdar://problem/73768161>