Bug 220890 – [WASM-References] Enable reference types by default

• Status: RESOLVED
• Resolution: FIXED
• Component: WebAssembly

[Dmitry]

[WASM-References] Enable reference types by default

[Dmitry]

Created attachment 418222 [details]
Patch

[Yusuke Suzuki]

I was worrying about whether enabling Wasm-references disables a lot of important tests in WPT because of early failures, but it looks like it is not. Some wrong WPT tests are failed, but its failure scope is limited to these wrong tests. And other important tests are still working correctly.
So, I think, enabling these flags and rebaselining these tests with the new expect files are the path.

[Yusuke Suzuki]

Can you also investigate these failures and ensure they are because of wrong tests?

[Dmitry]

Created attachment 418253 [details]
Patch

[Yusuke Suzuki]

Looks like EWS is failing. Can you rebaseline the expect files?

[Dmitry]

Created attachment 418269 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 418269 [details]
Patch

r=me is EWS gets green. If EWS gets red, please fix :)

[Yusuke Suzuki]

Comment on attachment 418269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418269&action=review

Ah, wait. Sorry, can you check the potential issue?

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any-expected.txt:3
> +FAIL Arguments for externref table set assert_equals: expected (undefined) undefined but got (object) null

Can you explain the reason of this failure?

[Yusuke Suzuki]

Comment on attachment 418269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418269&action=review

>> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/set-reftypes.tentative.any-expected.txt:3
>> +FAIL Arguments for externref table set assert_equals: expected (undefined) undefined but got (object) null
> 
> Can you explain the reason of this failure?

Talked with Dmitry at Slack. This is a real bug. This will be fixed in https://bugs.webkit.org/show_bug.cgi?id=220918, and this patch will be updated.

[Dmitry]

Created attachment 418716 [details]
Patch

[Dmitry]

Created attachment 418719 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 418719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418719&action=review

r=me if EWS gets green

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor.any-expected.txt:25
> +FAIL Stray argument WebAssembly.Table.prototype.constructor expects the second argument to be null or an instance of WebAssembly.Function

OK, this is because WebAssembly tests in WPT is obsolete after wasm-reference-types.

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor.any.worker-expected.txt:25
> +FAIL Stray argument WebAssembly.Table.prototype.constructor expects the second argument to be null or an instance of WebAssembly.Function

OK, this is because WebAssembly tests in WPT is obsolete after wasm-reference-types.

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/get-set.any-expected.txt:4
> +FAIL Missing arguments: set assert_throws_js: function "() => table.set(0)" did not throw

OK, this is because WebAssembly tests in WPT is obsolete after wasm-reference-types.

> LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/get-set.any.worker-expected.txt:4
> +FAIL Missing arguments: set assert_throws_js: function "() => table.set(0)" did not throw

OK, this is because WebAssembly tests in WPT is obsolete after wasm-reference-types.

[Yusuke Suzuki]

accessibility/mac/test.mp3/root.xml
accessibility/mac/test.mp3/boot.xml
are failing these days. Ignore them.

[EWS]

Committed r272074: <https://trac.webkit.org/changeset/272074>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418719 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73768161>