Bug 220918 – [WASM-References] Change default value for externref's tables from null to undefined

• Status: RESOLVED
• Resolution: FIXED
• Component: WebAssembly

[Dmitry]

[WASM-References] Change default value for externref's tables from null to undefined

[Dmitry]

Created attachment 418283 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 418283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418283&action=review

r=me with comments.

> Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp:126
> +            : callFrame->argument(1);

Use `uncheckedArgument(1)` since we already checked.

> Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp:99
> +            defaultValue = callFrame->argument(1);

Use `callFrame->uncheckedArgument(1);` since we already checked `callFrame->argumentCount() < 2`

> Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp:137
>      JSValue value = callFrame->argument(1);
> -    if (Options::useWebAssemblyReferences() && value.isUndefined())
> -        value = jsNull();
> +    if (Options::useWebAssemblyReferences() && callFrame->argumentCount() < 2)
> +        value = defaultValueForTable(table->table()->type());

This needs to be done after

    if (index >= table->length())
        return throwVMRangeError(globalObject, throwScope, "WebAssembly.Table.prototype.set expects an integer less than the length of the table"_s);


part. Can you move it, and add test for this?

[Dmitry]

Created attachment 418416 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 418416 [details]
Patch

r=me

[Yusuke Suzuki]

Comment on attachment 418416 [details]
Patch

EWS is getting stuck.

[EWS]

Committed r271903: <https://trac.webkit.org/changeset/271903>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418416 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73631096>