Bug 220792 - [webkitcorepy] Use AutoInstall for webkitcorepy deps as well
Summary: [webkitcorepy] Use AutoInstall for webkitcorepy deps as well
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-21 05:38 PST by Angelos Oikonomopoulos
Modified: 2021-01-21 09:04 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.57 KB, patch)
2021-01-21 05:51 PST, Angelos Oikonomopoulos
jbedard: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Angelos Oikonomopoulos 2021-01-21 05:38:03 PST
[webkitcorepy] Use AutoInstall for webkitcorepy deps as well
Comment 1 Angelos Oikonomopoulos 2021-01-21 05:51:02 PST
Created attachment 418033 [details]
Patch
Comment 2 Jonathan Bedard 2021-01-21 06:53:55 PST
Comment on attachment 418033 [details]
Patch

In most places, this would be the right approach, but webkitcorepy is a special case because it’s imported before the autoinstaller is configured (and not just in webkitpy, that’s also true in some Apple non-public code)

What I should have done is put the six import in task_pool inside the function (or functions) that are actually using it. If no one else posts a patch, I’ll get to it in the next hour or two.
Comment 3 Angelos Oikonomopoulos 2021-01-21 07:01:52 PST
(In reply to Jonathan Bedard from comment #2)
> Comment on attachment 418033 [details]
> Patch
> 
> In most places, this would be the right approach, but webkitcorepy is a
> special case because it’s imported before the autoinstaller is configured
> (and not just in webkitpy, that’s also true in some Apple non-public code)

Ah, so you need the autoinstaller configuration to be in the consumers of webkitcorepy? That makes sense.

> What I should have done is put the six import in task_pool inside the
> function (or functions) that are actually using it. If no one else posts a
> patch, I’ll get to it in the next hour or two.

Sure, I'll file a new bug.
Comment 4 Angelos Oikonomopoulos 2021-01-21 07:11:11 PST
https://bugs.webkit.org/show_bug.cgi?id=220795
Comment 5 Jonathan Bedard 2021-01-21 09:04:17 PST
Angelos fixed this in the other bug he linked, closing this one.