Bug 220795 - [webkitcorepy] Don't import six at the top level
Summary: [webkitcorepy] Don't import six at the top level
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 220791 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-21 07:06 PST by Angelos Oikonomopoulos
Modified: 2021-01-21 14:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2021-01-21 07:10 PST, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelos Oikonomopoulos 2021-01-21 07:06:10 PST 
[webkitcorepy] Don't import six at the top level
Comment 1 Angelos Oikonomopoulos 2021-01-21 07:10:47 PST 
Created attachment 418037 [details]
Patch
Comment 2 Aakash Jain 2021-01-21 08:05:32 PST 
Comment on attachment 418037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418037&action=review

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:338
> +        from six import reraise

Do we need to import it again whiling exiting?
Comment 3 Jonathan Bedard 2021-01-21 08:20:37 PST 
Comment on attachment 418037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418037&action=review

>> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:338
>> +        from six import reraise
> 
> Do we need to import it again whiling exiting?

We do, because we use it on line 352
Comment 4 EWS 2021-01-21 08:52:11 PST 
Committed r271692: <https://trac.webkit.org/changeset/271692>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418037 [details].
Comment 5 Radar WebKit Bug Importer 2021-01-21 08:54:51 PST 
<rdar://problem/73454252>
Comment 6 Aakash Jain 2021-01-21 14:37:23 PST 
*** Bug 220791 has been marked as a duplicate of this bug. ***