Bug 220544 - [build.webkit.org] Update force schedulers as per new buildbot
Summary: [build.webkit.org] Update force schedulers as per new buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency treegraph
 
Reported: 2021-01-12 08:44 PST by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.02 KB, patch)
2021-01-12 08:46 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-01-12 08:44:07 PST
[build.webkit.org] Update force schedulers as per new buildbot. Force schedulers class parameters have changed in newer Buildbot versions. We should change the code accordingly to support the new parameters.
Comment 1 Aakash Jain 2021-01-12 08:46:47 PST
ForceScheduler class in newer buildbot doesn't accept parameters like: branch, repository, project.
Comment 2 Aakash Jain 2021-01-12 08:46:53 PST
Created attachment 417458 [details]
Patch
Comment 3 Aakash Jain 2021-01-12 08:47:42 PST
Tested on dev instance.
Comment 4 Jonathan Bedard 2021-01-12 08:57:44 PST
Comment on attachment 417458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417458&action=review

> Tools/CISupport/build-webkit-org/loadConfig.py:91
> +            revision=StringParameter(name="revision", default="", regex=re.compile(r'^(\d*)$')),

What are the implications for this argument in a Git world?
Comment 5 Aakash Jain 2021-01-12 09:01:45 PST
(In reply to Jonathan Bedard from comment #4)
> What are the implications for this argument in a Git world?
Good thing is that we won't be using it in new buildbot anymore. In old buildbot, it is restricting that specified revision should be in svn revision format while doing a force build.
Comment 6 EWS 2021-01-12 09:30:59 PST
Committed r271406: <https://trac.webkit.org/changeset/271406>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417458 [details].
Comment 7 Radar WebKit Bug Importer 2021-01-12 09:31:14 PST
<rdar://problem/73044118>