media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html is consistently timing out on macOS WK2 bots after https://trac.webkit.org/changeset/271341/webkit --- /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline-expected.txt +++ /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline-actual.txt @@ -1,22 +1,5 @@ -Testing that entering fullscreen then going back into inline presents inline controls. +#PID UNRESPONSIVE - WebKitTestRunner (pid 1825) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - - -Media started playing, we pause it and enter fullscreen by clicking on the matching button. -PASS shadowRoot.querySelector('.media-controls').classList.contains('inline') is true - -Media entered fullscreen. -PASS shadowRoot.querySelector('.media-controls').classList.contains('fullscreen') is true - -We exit fullscreen by clicking on the matching button. - -Media exited fullscreen. -PASS shadowRoot.querySelector('.media-controls').classList.contains('inline') is true -PASS shadowRoot.querySelector('.start-button') is null - -PASS successfullyParsed is true - -TEST COMPLETE - +#EOF +#EOF https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-inline-to-fullscreen-to-inline.html
<rdar://problem/73024699>
Created attachment 417433 [details] Patch
Comment on attachment 417433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417433&action=review > LayoutTests/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). It would be helpful to have a description of what was changed and why it fixed the test.
Created attachment 417464 [details] Patch for landing
Comment on attachment 417433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417433&action=review >> LayoutTests/ChangeLog:6 >> + Reviewed by NOBODY (OOPS!). > > It would be helpful to have a description of what was changed and why it fixed the test. Agree! Updated the changelog in the patch for landing.
Committed r271407: <https://trac.webkit.org/changeset/271407> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417464 [details].