Bug 220530 - REGRESSION (r271341): media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html is timing out
Summary: REGRESSION (r271341): media/modern-media-controls/media-controller/media-cont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-11 20:34 PST by Ryan Haddad
Modified: 2021-01-12 10:57 PST (History)
9 users (show)

See Also:


Attachments
Patch (5.42 KB, patch)
2021-01-11 22:01 PST, Peng Liu
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (5.63 KB, patch)
2021-01-12 09:40 PST, Peng Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2021-01-11 20:34:59 PST
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html is consistently timing out on macOS WK2 bots after https://trac.webkit.org/changeset/271341/webkit

--- /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline-expected.txt
+++ /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline-actual.txt
@@ -1,22 +1,5 @@
-Testing that entering fullscreen then going back into inline presents inline controls.
+#PID UNRESPONSIVE - WebKitTestRunner (pid 1825)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-
-Media started playing, we pause it and enter fullscreen by clicking on the matching button.
-PASS shadowRoot.querySelector('.media-controls').classList.contains('inline') is true
-
-Media entered fullscreen.
-PASS shadowRoot.querySelector('.media-controls').classList.contains('fullscreen') is true
-
-We exit fullscreen by clicking on the matching button.
-
-Media exited fullscreen.
-PASS shadowRoot.querySelector('.media-controls').classList.contains('inline') is true
-PASS shadowRoot.querySelector('.start-button') is null
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+#EOF
+#EOF

https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-inline-to-fullscreen-to-inline.html
Comment 1 Radar WebKit Bug Importer 2021-01-11 20:35:21 PST
<rdar://problem/73024699>
Comment 2 Peng Liu 2021-01-11 22:01:51 PST
Created attachment 417433 [details]
Patch
Comment 3 Eric Carlson 2021-01-12 09:20:48 PST
Comment on attachment 417433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417433&action=review

> LayoutTests/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

It would be helpful to have a description of what was changed and why it fixed the test.
Comment 4 Peng Liu 2021-01-12 09:40:01 PST
Created attachment 417464 [details]
Patch for landing
Comment 5 Peng Liu 2021-01-12 09:41:50 PST
Comment on attachment 417433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417433&action=review

>> LayoutTests/ChangeLog:6
>> +        Reviewed by NOBODY (OOPS!).
> 
> It would be helpful to have a description of what was changed and why it fixed the test.

Agree!
Updated the changelog in the patch for landing.
Comment 6 EWS 2021-01-12 10:57:37 PST
Committed r271407: <https://trac.webkit.org/changeset/271407>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417464 [details].