Bug 220466 – A video element needs to ignore the request to enter/exit fullscreen before the current fullscreen mode change is completed

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

A video element needs to ignore the request to enter/exit fullscreen before the current fullscreen mode change is done

[Peng Liu]

<rdar://problem/72902078>

[Peng Liu]

Created attachment 417276 [details]
Patch

[Peng Liu]

Created attachment 417302 [details]
Fix a layout test failure

[EWS]

Committed r271341: <https://trac.webkit.org/changeset/271341>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417302 [details].

[Philippe Normand]

This test is no longer flaky on GTK/WPE, it's now a timeout... Progress?

[Philippe Normand]

Comment on attachment 417302 [details]
Fix a layout test failure

View in context: https://bugs.webkit.org/attachment.cgi?id=417302&action=review

> LayoutTests/media/media-fullscreen.js:44
> +        await testExpectedEventually("internals.isChangingPresentationMode(mediaElement)", false);

GTK/WPE don't enable VIDEO_PRESENTATION_MODE yet, I suppose that's why the test now times out for us.

[Truitt Savell]

media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

this test is now timing out after the changes in https://trac.webkit.org/changeset/271341/webkit

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-fullscreen-change.html

[Peng Liu]

(In reply to Philippe Normand from comment #6)
> Comment on attachment 417302 [details]
> Fix a layout test failure
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417302&action=review
> 
> > LayoutTests/media/media-fullscreen.js:44
> > +        await testExpectedEventually("internals.isChangingPresentationMode(mediaElement)", false);
> 
> GTK/WPE don't enable VIDEO_PRESENTATION_MODE yet, I suppose that's why the
> test now times out for us.

So we had better disable the test for GTK/WPE?

[Peng Liu]

Reopening to attach new patch.

[Peng Liu]

Created attachment 417392 [details]
A follow-up patch to fix test timeout

[EWS]

Committed r271377: <https://trac.webkit.org/changeset/271377>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417392 [details].