WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
220237
[Flatpak SDK] Update GStreamer and Mesa
https://bugs.webkit.org/show_bug.cgi?id=220237
Summary
[Flatpak SDK] Update GStreamer and Mesa
Philippe Normand
Reported
2021-01-04 03:45:54 PST
.
Attachments
Patch
(34.99 KB, patch)
2021-01-04 09:11 PST
,
Philippe Normand
no flags
Details
Formatted Diff
Diff
Patch
(34.94 KB, patch)
2021-01-07 08:44 PST
,
Philippe Normand
aperez
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2021-01-04 09:11:11 PST
Created
attachment 416950
[details]
Patch
Lauro Moura
Comment 2
2021-01-06 20:24:22 PST
Comment on
attachment 416950
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=416950&action=review
Tested in a local SDK build together with GTK4's patches from
bug219983
and
bug219844
and there were no noticeable regressions in the tests. Other than the mismatch in the changelog, seems good.
> Tools/buildstream/ChangeLog:10 > + - GStreamer 1.18.0 -> 1.18.3
Should be 1.18.2, no?
Philippe Normand
Comment 3
2021-01-07 01:50:28 PST
Comment on
attachment 416950
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=416950&action=review
>> Tools/buildstream/ChangeLog:10 >> + - GStreamer 1.18.0 -> 1.18.3 > > Should be 1.18.2, no?
Indeed!
Philippe Normand
Comment 4
2021-01-07 08:44:26 PST
Created
attachment 417181
[details]
Patch
Adrian Perez
Comment 5
2021-01-15 05:22:14 PST
Comment on
attachment 417181
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=417181&action=review
> Tools/buildstream/elements/sdk/mesa.bst:71 > + -Dplatforms=x11,wayland
Shouldn't we leave the “drm” platform enabled here? We would need it if/when
bug #217477
is taken care of to be able to use “cog --platform=drm” 🤔️
Adrian Perez
Comment 6
2021-01-15 05:24:24 PST
(In reply to Adrian Perez from
comment #5
)
> Comment on
attachment 417181
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=417181&action=review
> > > Tools/buildstream/elements/sdk/mesa.bst:71 > > + -Dplatforms=x11,wayland > > Shouldn't we leave the “drm” platform enabled here? We would need it if/when >
bug #217477
is taken care of to be able to use “cog --platform=drm” 🤔️
FWIW, we can always re-add it later on.
Philippe Normand
Comment 7
2021-01-15 05:33:04 PST
As of
https://gitlab.freedesktop.org/mesa/mesa/commit/cb728f28acbf8982d37aa3863cae58db95a439ca
DRM is now unconditionally enabled.
Philippe Normand
Comment 8
2021-01-15 05:35:03 PST
(In reply to Philippe Normand from
comment #7
)
> As of >
https://gitlab.freedesktop.org/mesa/mesa/commit/
> cb728f28acbf8982d37aa3863cae58db95a439ca DRM is now unconditionally enabled.
This might not be the right commit, but I do remember the build failing because the DRM option couldn't be found anymore ;)
Adrian Perez
Comment 9
2021-01-15 05:56:45 PST
(In reply to Philippe Normand from
comment #7
)
> As of >
https://gitlab.freedesktop.org/mesa/mesa/commit/
> cb728f28acbf8982d37aa3863cae58db95a439ca DRM is now unconditionally enabled.
Great, let's land the patch, then 😼️
Philippe Normand
Comment 10
2021-01-19 10:54:40 PST
Landed in
r271519
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug