Bug 217477 - [WPE] Include cog build artefacts in built product archive
Summary: [WPE] Include cog build artefacts in built product archive
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
Keywords: InRadar
Depends on:
Reported: 2020-10-08 08:48 PDT by Philippe Normand
Modified: 2021-03-17 01:57 PDT (History)
5 users (show)

See Also:

Patch (3.57 KB, patch)
2021-03-14 03:25 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-10-08 08:48:35 PDT
As Cog is a bit nicer than the current WPE MiniBrowser I wonder if we could ship it in the nightly zip archives produced by the bots. Any thoughts?
Comment 1 Carlos Alberto Lopez Perez 2020-10-09 05:56:48 PDT
A possible implementation idea is:

1. Start by having a new script (in Tools/Scripts) that allow to download and build cog [1] against the webkit built product, and also that allows to run that built cog (i guess that without installing it, just from the build directory)

2. Once we have this script, if we want to include cog in the built-product zip files (those that are downloaded via the script Tools/Scripts/webkit-flatpak-run-nightly) we can run this new script as a new step after build-webkit on the build bots (build-only bots)

[1] I would even go for downloading just last cog master (instead of a specific git commit). That would even allow us to start testing that cog builds against the last wpewebkit on the build.webkit.org CI if we do 2.
Comment 2 Philippe Normand 2021-03-05 09:03:44 PST
Getting back to this, I recently added Cog build support, it can be enabled with this cmake option: `-DENABLE_COG=ON`.

Could we enable that on the bots and pack the cog artefacts in the zip archives for the nightlies? Shouldn't have a major impact on the final zip size.
Comment 3 Philippe Normand 2021-03-14 03:25:23 PDT
Created attachment 423122 [details]
Comment 4 Adrian Perez 2021-03-16 09:45:20 PDT
Comment on attachment 423122 [details]

The Windows EWS failure seems unrelated, FWIW :]
Comment 5 EWS 2021-03-17 01:56:52 PDT
Committed r274554: <https://commits.webkit.org/r274554>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423122 [details].
Comment 6 Radar WebKit Bug Importer 2021-03-17 01:57:15 PDT