+++ This bug was initially created as a clone of Bug #219990 +++ > Simplify code related to dispatchToRenderThread in WebAudio: > 1. AudioDestination::start() now always gets called with a non-null dispatchToRenderThread lambda. In the case where there is no AudioWorkletThread to dispatch to, the lambda simply calls its task synchronously. This is the cause of the regression in GStreamer ports, when there is no AudioWorklet, the dispatchCondition in WebKitWebAudioSourceGStreamer is fired synchronously before the corresponding wait call, introducing the infinite wait...
Created attachment 416749 [details] Patch
Comment on attachment 416749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416749&action=review > Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h:59 > + Optional<CompletionHandler<void(bool)>> m_startupCompletionHandler; Does not need to be Optional<>. CompletionHandler has a null state. > Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h:60 > + Optional<CompletionHandler<void(bool)>> m_stopCompletionHandler; Ditto.
Committed r271197: <https://trac.webkit.org/changeset/271197>