RESOLVED FIXED Bug 219990
[WebAudio] Simplify code related to dispatchToRenderThread 
https://bugs.webkit.org/show_bug.cgi?id=219990
Summary [WebAudio] Simplify code related to dispatchToRenderThread
Chris Dumez
Reported 2020-12-17 12:18:45 PST
Simplify code related to dispatchToRenderThread in WebAudio: 1. AudioDestination::start() now always gets called with a non-null dispatchToRenderThread lambda. In the case where there is no AudioWorkletThread to dispatch to, the lambda simply calls its task synchronously. 2. For Cocoa ports, make it so that only AudioDestinationCocoa needs to worry about the dispatchToRenderThread lambda. The dispatchToRenderThread lambda is no longer exposed to subclasses such as MockAudioDestinationCocoa & RemoteAudioDestinationProxy.
Attachments
Patch (18.91 KB, patch)
2020-12-17 12:42 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.01 KB, patch)
2020-12-17 13:02 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (21.95 KB, patch)
2020-12-17 13:05 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.51 KB, patch)
2020-12-17 13:11 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.81 KB, patch)
2020-12-17 13:16 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-12-17 12:42:21 PST
Created attachment 416452 [details] Patch
Chris Dumez
Comment 2 2020-12-17 13:02:47 PST
Created attachment 416458 [details] Patch
Chris Dumez
Comment 3 2020-12-17 13:05:25 PST
Created attachment 416459 [details] Patch
Chris Dumez
Comment 4 2020-12-17 13:11:02 PST
Created attachment 416460 [details] Patch
Chris Dumez
Comment 5 2020-12-17 13:16:36 PST
Created attachment 416461 [details] Patch
Geoffrey Garen
Comment 6 2020-12-17 14:02:31 PST
Comment on attachment 416461 [details] Patch r=me
EWS
Comment 7 2020-12-17 14:24:09 PST
Committed r270947: <https://trac.webkit.org/changeset/270947> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416461 [details].
Radar WebKit Bug Importer
Comment 8 2020-12-17 14:25:18 PST
<rdar://problem/72441076>
Note You need to log in before you can comment on or make changes to this bug.