Bug 220094 - Remove non-inclusive language from tests in http/tests/contentextensions/
Summary: Remove non-inclusive language from tests in http/tests/contentextensions/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks: 213092
  Show dependency treegraph
 
Reported: 2020-12-22 11:08 PST by Beth Dakin
Modified: 2021-11-08 16:16 PST (History)
6 users (show)

See Also:


Attachments
Patch (10.12 KB, patch)
2020-12-22 11:11 PST, Beth Dakin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2020-12-22 11:08:14 PST
Remove non-inclusive language from tests in http/tests/contentextensions/ 

I skipped this directory before because it confused me. But I think it is a straightforward rename after all!
Comment 1 Beth Dakin 2020-12-22 11:11:07 PST
Created attachment 416676 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-12-22 13:11:06 PST
Comment on attachment 416676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416676&action=review

> LayoutTests/http/tests/contentextensions/allowlist.html.json:15
> +            "url-filter": "whitelist"

You have to leave this one?
Comment 3 Beth Dakin 2020-12-22 13:13:11 PST
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 416676 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416676&action=review
> 
> > LayoutTests/http/tests/contentextensions/allowlist.html.json:15
> > +            "url-filter": "whitelist"
> 
> You have to leave this one?

That's just the diff being confusing! It shows the file move in svn as an unchanged file, and then shows the diff to re-name that to allowlist separately. This has tripped me up several times when looking over these diffs.
Comment 4 EWS 2020-12-22 13:19:17 PST
Committed r271063: <https://trac.webkit.org/changeset/271063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416676 [details].
Comment 5 Radar WebKit Bug Importer 2020-12-22 13:20:20 PST
<rdar://problem/72598396>
Comment 6 Alex Christensen 2021-11-08 16:16:01 PST
r285441