WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
220094
Remove non-inclusive language from tests in http/tests/contentextensions/
https://bugs.webkit.org/show_bug.cgi?id=220094
Summary
Remove non-inclusive language from tests in http/tests/contentextensions/
Beth Dakin
Reported
2020-12-22 11:08:14 PST
Remove non-inclusive language from tests in http/tests/contentextensions/ I skipped this directory before because it confused me. But I think it is a straightforward rename after all!
Attachments
Patch
(10.12 KB, patch)
2020-12-22 11:11 PST
,
Beth Dakin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2020-12-22 11:11:07 PST
Created
attachment 416676
[details]
Patch
Simon Fraser (smfr)
Comment 2
2020-12-22 13:11:06 PST
Comment on
attachment 416676
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=416676&action=review
> LayoutTests/http/tests/contentextensions/allowlist.html.json:15 > + "url-filter": "whitelist"
You have to leave this one?
Beth Dakin
Comment 3
2020-12-22 13:13:11 PST
(In reply to Simon Fraser (smfr) from
comment #2
)
> Comment on
attachment 416676
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=416676&action=review
> > > LayoutTests/http/tests/contentextensions/allowlist.html.json:15 > > + "url-filter": "whitelist" > > You have to leave this one?
That's just the diff being confusing! It shows the file move in svn as an unchanged file, and then shows the diff to re-name that to allowlist separately. This has tripped me up several times when looking over these diffs.
EWS
Comment 4
2020-12-22 13:19:17 PST
Committed
r271063
: <
https://trac.webkit.org/changeset/271063
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 416676
[details]
.
Radar WebKit Bug Importer
Comment 5
2020-12-22 13:20:20 PST
<
rdar://problem/72598396
>
Alex Christensen
Comment 6
2021-11-08 16:16:01 PST
r285441
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug