Bug 220018 - [Mojave] webanimations/accelerated-transform-related-animation-property-order.html is failing
Summary: [Mojave] webanimations/accelerated-transform-related-animation-property-order...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-18 10:19 PST by Ryan Haddad
Modified: 2021-03-07 12:26 PST (History)
5 users (show)

See Also:

Attachments
actual (10.26 KB, image/png)
2020-12-18 14:04 PST, Ryan Haddad 		no flags Details
expected (10.24 KB, image/png)
2020-12-18 14:04 PST, Ryan Haddad 		no flags Details
Patch (1.54 KB, patch)
2021-03-06 12:15 PST, Antoine Quint 		sam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2020-12-18 10:20:13 PST 
<rdar://problem/72471813>
Comment 2 Ryan Haddad 2020-12-18 10:23:56 PST 
Marked test as failing in https://trac.webkit.org/changeset/270973/webkit
Comment 3 Ryan Haddad 2020-12-18 14:04:08 PST 
Created attachment 416544 [details]
actual
Comment 4 Ryan Haddad 2020-12-18 14:04:18 PST 
Created attachment 416545 [details]
expected
Comment 5 Ryan Haddad 2020-12-18 15:18:27 PST 
It looks like this test was previously marked as failing, then that was removed as part of https://bugs.webkit.org/show_bug.cgi?id=217851
Comment 6 Antoine Quint 2021-03-06 12:15:29 PST 
Created attachment 422504 [details]
Patch
Comment 7 Sam Weinig 2021-03-07 09:01:25 PST 
Comment on attachment 422504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422504&action=review

> LayoutTests/ChangeLog:8
> +        * platform/mac-wk2/TestExpectations:

Can you add a bit here about what you are doing? Is the test now passing?
Comment 8 Antoine Quint 2021-03-07 12:23:11 PST 
(In reply to Sam Weinig from comment #7)
> Comment on attachment 422504 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422504&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        * platform/mac-wk2/TestExpectations:
> 
> Can you add a bit here about what you are doing? Is the test now passing?

I've been seeing it pass locally for quite some time, and this failure was on Mojave which I think we've dropped support for in ToT. Will check the bots to see how that test has been doing.
Comment 9 Antoine Quint 2021-03-07 12:24:22 PST 
The bots are looking good indeed: https://results.webkit.org/?suite=layout-tests&test=webanimations%2Faccelerated-transform-related-animation-property-order.html. I'll add some notes in the ChangeLog!
Comment 10 Antoine Quint 2021-03-07 12:26:31 PST 
Committed r274056 (234992@main): <https://commits.webkit.org/234992@main>